-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(Coachmark): increases test coverage #6496
Merged
devadula-nandan
merged 5 commits into
carbon-design-system:main
from
AlexanderMelox:6262--coachmark-test-coverage
Nov 26, 2024
Merged
test(Coachmark): increases test coverage #6496
devadula-nandan
merged 5 commits into
carbon-design-system:main
from
AlexanderMelox:6262--coachmark-test-coverage
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexanderMelox
requested review from
elycheea and
devadula-nandan
and removed request for
a team
November 20, 2024 20:42
✅ Deploy Preview for carbon-for-ibm-products ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-products-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6496 +/- ##
==========================================
+ Coverage 79.61% 79.83% +0.22%
==========================================
Files 394 394
Lines 12879 12871 -8
Branches 4268 4257 -11
==========================================
+ Hits 10254 10276 +22
+ Misses 2625 2595 -30
|
packages/ibm-products/src/components/Coachmark/Coachmark.test.js
Outdated
Show resolved
Hide resolved
elycheea
approved these changes
Nov 25, 2024
devadula-nandan
approved these changes
Nov 26, 2024
Merged
via the queue into
carbon-design-system:main
with commit Nov 26, 2024
1d049e0
33 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6262
This PR increases code coverage for Coachmark