Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): use CSS logical properties #5315

Open
wants to merge 42 commits into
base: main
Choose a base branch
from

Conversation

kennylam
Copy link
Member

@kennylam kennylam commented May 22, 2024

Note

Merging blocked by #5236

Closes #3556

This removes the local stylelint-config-ibm-products config in favor of the published Carbon package stylelint-config-carbon. In addition to this update, all CSS properties have been converted to their logical counterparts.

What did you change?

New

  • stylelint-config-carbon package

Changed

  • update all CSS style properties to use logical properties

Removed

  • stylelint-config-ibm-products config files

How did you test and verify your work?

  • yarn lint:styles
  • utilize VRT tool such as Percy to ensure no visual bugs were introduced (Setup VRT #5236)

Copy link

netlify bot commented May 22, 2024

Deploy Preview for carbon-for-ibm-products ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/carbon-for-ibm-products/deploys/66c75e4204cb7056879000f0
😎 Deploy Preview https://deploy-preview-5315--carbon-for-ibm-products.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kennylam kennylam changed the title deps(Stylelint): update Stylelint package feat(Stylelint): update Stylelint package May 22, 2024
@kennylam kennylam changed the title feat(Stylelint): update Stylelint package feat(styles): use CSS logical properties and update Stylelint package May 23, 2024
@kennylam kennylam changed the base branch from main to feat/percy-integration August 14, 2024 12:56
@kennylam kennylam changed the title feat(styles): use CSS logical properties and update Stylelint package feat(styles): use CSS logical properties Aug 14, 2024
@kennylam kennylam closed this Aug 22, 2024
@kennylam kennylam reopened this Aug 22, 2024
@kennylam kennylam closed this Aug 22, 2024
@kennylam kennylam reopened this Aug 22, 2024
@kennylam kennylam marked this pull request as ready for review August 22, 2024 15:00
@kennylam kennylam requested review from elycheea, matthewgallo and a team as code owners August 22, 2024 15:00
@kennylam kennylam force-pushed the deps/remove-local-stylelint branch from 5d21864 to 3cf3d2d Compare September 16, 2024 21:52
@elycheea elycheea changed the base branch from feat/percy-integration to main December 18, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement CSS logical properties
2 participants