Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to build 2.57.0 due to framer-motion bump #6672

Closed
2 tasks done
tom-youd opened this issue Jan 8, 2025 · 2 comments
Closed
2 tasks done

Unable to build 2.57.0 due to framer-motion bump #6672

tom-youd opened this issue Jan 8, 2025 · 2 comments

Comments

@tom-youd
Copy link
Contributor

tom-youd commented Jan 8, 2025

Package

Carbon for IBM Products

Description

When using IBM products to build say a webpack build or build a storybook you get the following error -

<i> [webpack-dev-middleware] wait until bundle finished
WARN Module not found: Error: Can't resolve '@emotion/is-prop-valid' in '/Users/tomyoud/cp4i/cp4i-canvas/node_modules/framer-motion/dist/es/render/dom/utils'
[
  "ModuleNotFoundError: Module not found: Error: Can't resolve '@emotion/is-prop-valid' in '/Users/tomyoud/cp4i/cp4i-canvas/node_modules/framer-motion/dist/es/render/dom/utils'\n" +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/webpack/lib/Compilation.js:2123:28\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/webpack/lib/NormalModuleFactory.js:923:13\n' +
    '    at eval (eval at create (/Users/tomyoud/cp4i/cp4i-canvas/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:10:1)\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/webpack/lib/NormalModuleFactory.js:339:22\n' +
    '    at eval (eval at create (/Users/tomyoud/cp4i/cp4i-canvas/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/webpack/lib/NormalModuleFactory.js:520:22\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/webpack/lib/NormalModuleFactory.js:151:10\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/webpack/lib/NormalModuleFactory.js:783:25\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/webpack/lib/NormalModuleFactory.js:1008:8\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/webpack/lib/NormalModuleFactory.js:1137:5\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/neo-async/async.js:6883:13\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/webpack/lib/NormalModuleFactory.js:1120:45\n' +
    '    at finishWithoutResolve (/Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/Resolver.js:567:11)\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/Resolver.js:656:15\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/Resolver.js:718:5\n' +
    '    at eval (eval at create (/Users/tomyoud/cp4i/cp4i-canvas/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/Resolver.js:718:5\n' +
    '    at eval (eval at create (/Users/tomyoud/cp4i/cp4i-canvas/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:27:1)\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/DescriptionFilePlugin.js:89:43\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/Resolver.js:718:5\n' +
    '    at eval (eval at create (/Users/tomyoud/cp4i/cp4i-canvas/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/forEachBail.js:39:13\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/AliasPlugin.js:177:14\n' +
    '    at next (/Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/forEachBail.js:35:3)\n' +
    '    at forEachBail (/Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/forEachBail.js:49:9)\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/AliasPlugin.js:62:5\n' +
    '    at _next0 (eval at create (/Users/tomyoud/cp4i/cp4i-canvas/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:8:1)\n' +
    '    at eval (eval at create (/Users/tomyoud/cp4i/cp4i-canvas/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:30:1)\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/Resolver.js:718:5\n' +
    '    at eval (eval at create (/Users/tomyoud/cp4i/cp4i-canvas/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/Resolver.js:718:5\n' +
    '    at eval (eval at create (/Users/tomyoud/cp4i/cp4i-canvas/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/Resolver.js:718:5\n' +
    '    at eval (eval at create (/Users/tomyoud/cp4i/cp4i-canvas/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:27:1)\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/DescriptionFilePlugin.js:89:43\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/Resolver.js:718:5\n' +
    '    at eval (eval at create (/Users/tomyoud/cp4i/cp4i-canvas/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/Resolver.js:718:5\n' +
    '    at eval (eval at create (/Users/tomyoud/cp4i/cp4i-canvas/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:15:1)\n' +
    '    at /Users/tomyoud/cp4i/cp4i-canvas/node_modules/enhanced-resolve/lib/DirectoryExistsPlugin.js:41:15\n' +
    '    at process.processTicksAndRejections (node:internal/process/task_queues:81:21)'
]

When you look at a repo after installing the dependencies I do noticed that @emotion/is-prop-valid is not in package-lock.json
On further inspection it looks like @emotion/is-prop-valid is an optional dependency.

Component(s) impacted

All

Browser

Chrome

@carbon/ibm-products (previously @carbon/ibm-cloud-cognitive) version

2.57.0

Suggested Severity

Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.

Product/offering

Cloud Pak for Integration

CodeSandbox or Stackblitz example

n/a

Steps to reproduce the issue (if applicable)

No response

Release date (if applicable)

No response

Code of Conduct

@tom-youd
Copy link
Contributor Author

tom-youd commented Jan 8, 2025

Looks like framer-motion has been released for a while and I can't see any bugs on their issues board.

I'll raise a PR (see below) to add @emotion/is-prop-valid as a dependency within this repo

@matthewgallo
Copy link
Member

This is now resolved with 2.57.1 rolling back to the previous version of framer-motion.

@github-project-automation github-project-automation bot moved this from Needs triage 🧐 to Done 🚀 in Carbon for IBM Products Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🚀
Development

Successfully merging a pull request may close this issue.

2 participants