-
Notifications
You must be signed in to change notification settings - Fork 142
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: reorganise our documentation files into a /docs folder (#1128)
- Loading branch information
Showing
9 changed files
with
54 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
# PR reviews | ||
|
||
When reviewing a PR, check that our | ||
[code guidelines](https://github.com/carbon-design-system/ibm-cloud-cognitive/blob/master/docs/CODE_GUIDELINES.md) | ||
are followed, and keep an eye on the | ||
[release review guidelines](https://github.com/carbon-design-system/ibm-cloud-cognitive/blob/master/docs/reviews/RELEASE_REVIEW_GUIDELINES.md). | ||
|
||
Each PR should be reviewed based on these criteria where applicable. | ||
|
||
## New production dependencies | ||
|
||
If a PR introduces new dependencies in `package.json`, paste the following | ||
checklist into the PR as a comment and check the items off before approving. | ||
|
||
**Tip** You should be able to copy and paste the section below directly into a | ||
GitHub comment, then check where criteria passed, strike out where not | ||
applicable. | ||
|
||
`## Review of dependencies` | ||
|
||
`- [ ]` Verify the dependency has previously been | ||
[pedigree reviewed](https://pedigree-service.wdc1a.cirrus.ibm.com)\ | ||
`- [ ]` Verify the dependency [doesn't contain any vulnerabilities](https://snyk.io/vuln)\ | ||
`- [ ]` Verify the dependency [bundle size](https://bundlephobia.com) is | ||
acceptable\ | ||
`- [ ]` Verify the dependency is [actively maintained](https://www.npmtrends.com)\ | ||
`- [ ]` Verify license conditions are met e.g. forwarding of copyright if | ||
necessary. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters