Skip to content

Commit

Permalink
Merge branch 'main' into fix-6460
Browse files Browse the repository at this point in the history
  • Loading branch information
makafsal authored Dec 11, 2024
2 parents 94d382c + c6f0ac0 commit 29763cd
Show file tree
Hide file tree
Showing 29 changed files with 417 additions and 113 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/process-pr-review-data.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,6 @@ jobs:
github.event.workflow_run.conclusion == 'success'
steps:
- uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
- name: Setup Node.js
uses: actions/setup-node@v2
with:
node-version: '20.x'
cache: yarn
- uses: ./actions/add-review-labels
with:
APP_ID: ${{ secrets.APP_ID }}
Expand Down
11 changes: 11 additions & 0 deletions config/jest-config-ibm-cloud-cognitive/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,17 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [1.15.0-rc.0](https://github.com/carbon-design-system/ibm-products/compare/jest-config-ibm-cloud-cognitive@[email protected]) (2024-12-09)


### Bug Fixes

* update accessibility-checker version ([#6525](https://github.com/carbon-design-system/ibm-products/issues/6525)) ([d8c7051](https://github.com/carbon-design-system/ibm-products/commit/d8c70518087e7e41fdf1aa45cbbf692389058d56))





# [1.14.0](https://github.com/carbon-design-system/ibm-products/compare/jest-config-ibm-cloud-cognitive@[email protected]) (2024-12-04)

**Note:** Version bump only for package jest-config-ibm-cloud-cognitive
Expand Down
2 changes: 1 addition & 1 deletion config/jest-config-ibm-cloud-cognitive/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "jest-config-ibm-cloud-cognitive",
"private": true,
"version": "1.14.0",
"version": "1.15.0-rc.0",
"license": "Apache-2.0",
"main": "index.js",
"repository": {
Expand Down
8 changes: 8 additions & 0 deletions config/storybook-addon-carbon-theme/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,14 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [2.5.0-rc.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/[email protected]...@carbon/[email protected]) (2024-12-09)

**Note:** Version bump only for package @carbon/storybook-addon-theme





# [2.4.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/[email protected]...@carbon/[email protected]) (2024-12-04)

**Note:** Version bump only for package @carbon/storybook-addon-theme
Expand Down
2 changes: 1 addition & 1 deletion config/storybook-addon-carbon-theme/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@carbon/storybook-addon-theme",
"description": "Carbon theme switcher for Storybook",
"version": "2.4.0",
"version": "2.5.0-rc.0",
"license": "Apache-2.0",
"main": "dist/react.js",
"repository": {
Expand Down
16 changes: 16 additions & 0 deletions packages/core/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,22 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [2.32.0-rc.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/[email protected]...@carbon/[email protected]) (2024-12-09)


### Bug Fixes

* update to Carbon 11 compatible versions to latest ([#6437](https://github.com/carbon-design-system/ibm-products/issues/6437)) ([48d5c34](https://github.com/carbon-design-system/ibm-products/commit/48d5c34dca79a4b00fc69391a513431fa21295ee))


### Features

* add utils section to storybook ([#6394](https://github.com/carbon-design-system/ibm-products/issues/6394)) ([711eb72](https://github.com/carbon-design-system/ibm-products/commit/711eb72ef00d1f1935fd0fcec9e0c0383dff53dc))





# [2.31.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/[email protected]...@carbon/[email protected]) (2024-12-04)

**Note:** Version bump only for package @carbon/ibm-cloud-cognitive-core
Expand Down
4 changes: 2 additions & 2 deletions packages/core/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@carbon/ibm-cloud-cognitive-core",
"private": true,
"version": "2.31.0",
"version": "2.32.0-rc.0",
"license": "Apache-2.0",
"main": "scripts/build.js",
"repository": {
Expand Down Expand Up @@ -29,7 +29,7 @@
},
"devDependencies": {
"@carbon/grid": "^11.29.0",
"@carbon/ibm-products-styles": "^2.51.0",
"@carbon/ibm-products-styles": "^2.52.0-rc.0",
"@carbon/layout": "^11.28.0",
"@carbon/motion": "^11.24.0",
"@carbon/react": "^1.71.1",
Expand Down
16 changes: 16 additions & 0 deletions packages/ibm-products-styles/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,22 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [2.52.0-rc.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/[email protected]...@carbon/[email protected]) (2024-12-09)


### Bug Fixes

* **pageHeader:** menu button overflow issue on small screens ([#6502](https://github.com/carbon-design-system/ibm-products/issues/6502)) ([0072e42](https://github.com/carbon-design-system/ibm-products/commit/0072e424fc1f25fbf58be67f7d4d792643f26c30))


### Features

* **BreadcrumbWithOverflow:** adopt overflowMenuV12 and floating ui ([#6411](https://github.com/carbon-design-system/ibm-products/issues/6411)) ([f716852](https://github.com/carbon-design-system/ibm-products/commit/f716852c979a0b9556e853fad7e7a7774b4c6579))





# [2.51.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/[email protected]...@carbon/[email protected]) (2024-12-04)

**Note:** Version bump only for package @carbon/ibm-products-styles
Expand Down
4 changes: 2 additions & 2 deletions packages/ibm-products-styles/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@carbon/ibm-products-styles",
"description": "Carbon for IBM Products styles",
"version": "2.51.0",
"version": "2.52.0-rc.0",
"license": "Apache-2.0",
"installConfig": {
"hoistingLimits": "none"
Expand Down Expand Up @@ -52,7 +52,7 @@
"cross-env": "^7.0.3",
"glob": "^10.3.10",
"jest": "^29.7.0",
"jest-config-ibm-cloud-cognitive": "^1.14.0",
"jest-config-ibm-cloud-cognitive": "^1.15.0-rc.0",
"jest-environment-jsdom": "^29.7.0",
"npm-check-updates": "^16.14.12",
"npm-run-all": "^4.1.5",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,10 @@ p.c4p--about-modal__copyright-text:first-child {
fill: var(--cds-button-danger-primary, #da1e28);
}
.c4p--apikey-modal__checkmark-icon {
fill: var(--cds-button-primary, #0f62fe);
}
.c4p--action-set {
align-items: stretch;
justify-content: flex-end;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,7 @@ $block-class: #{c4p-settings.$pkg-prefix}--apikey-modal;
.#{$block-class}__error-icon svg {
fill: $button-danger-primary;
}

.#{$block-class}__checkmark-icon {
fill: $button-primary;
}
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,8 @@ $action-set-block-class: #{c4p-settings.$pkg-prefix}--action-set;
border-right: 1px solid $border-subtle-02;
}
&.#{$block-class}.#{$block-class}--has-slug,
&.#{$block-class}.#{$block-class}--has-ai-label {
&.#{$block-class}.#{$block-class}--has-ai-label,
&.#{$block-class}.#{$block-class}--has-decorator {
border-color: transparent;
box-shadow: inset 0 -80px 70px -65px $ai-inner-shadow,
0 4px 10px 2px $ai-drop-shadow;
Expand Down Expand Up @@ -199,14 +200,16 @@ $action-set-block-class: #{c4p-settings.$pkg-prefix}--action-set;
&.#{$block-class}:has(.#{$block-class}__action-toolbar),
&.#{$block-class}--has-action-toolbar,
&.#{$block-class}--has-slug,
&.#{$block-class}--has-ai-label {
&.#{$block-class}--has-ai-label,
&.#{$block-class}--has-decorator {
--#{$block-class}--title-padding-right: #{$spacing-10};
}

&.#{$block-class}:has(.#{$block-class}__action-toolbar),
&.#{$block-class}--has-action-toolbar {
&.#{$block-class}--has-slug,
&.#{$block-class}--has-ai-label {
&.#{$block-class}--has-ai-label,
&.#{$block-class}--has-decorator {
--#{$block-class}--title-padding-right: #{$spacing-11};
}
}
Expand Down Expand Up @@ -313,7 +316,8 @@ $action-set-block-class: #{c4p-settings.$pkg-prefix}--action-set;
}

&.#{$block-class}--has-slug .#{$block-class}--scrolls,
&.#{$block-class}--has-ai-label .#{$block-class}--scrolls {
&.#{$block-class}--has-ai-label .#{$block-class}--scrolls,
&.#{$block-class}--has-decorator .#{$block-class}--scrolls {
@include utilities.ai-popover-gradient('default', 0, 'layer');

box-shadow: inset 0 -80px 70px -65px $ai-inner-shadow,
Expand Down Expand Up @@ -368,7 +372,8 @@ $action-set-block-class: #{c4p-settings.$pkg-prefix}--action-set;
}

.#{$block-class}__slug-and-close,
.#{$block-class}__ai-label-and-close {
.#{$block-class}__ai-label-and-close,
.#{$block-class}__decorator-and-close {
position: absolute;
z-index: 10; /* must be higher than title container border bottom */
top: 0;
Expand Down Expand Up @@ -470,7 +475,9 @@ $action-set-block-class: #{c4p-settings.$pkg-prefix}--action-set;
inset: 0;
}

/* stylelint-disable-next-line carbon/theme-token-use */
.#{$block-class}--has-slug + .#{$block-class}__overlay,
.#{$block-class}--has-ai-label + .#{$block-class}__overlay {
.#{$block-class}--has-ai-label + .#{$block-class}__overlay,
.#{$block-class}--has-decorator + .#{$block-class}__overlay {
background-color: $ai-overlay;
}
14 changes: 14 additions & 0 deletions packages/ibm-products-web-components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,20 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [0.5.0-rc.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/[email protected]...@carbon/[email protected]) (2024-12-09)


### Bug Fixes

* **Side Panel Web components:** storybook controls issue ([#6500](https://github.com/carbon-design-system/ibm-products/issues/6500)) ([19a7536](https://github.com/carbon-design-system/ibm-products/commit/19a75363d0683ed6765e0d713c3f68878eaeaef2))
* **Tearsheet in Web Components:** cancel button not working as expected ([#6458](https://github.com/carbon-design-system/ibm-products/issues/6458)) ([2461f81](https://github.com/carbon-design-system/ibm-products/commit/2461f8120431c125ceb826ccb5d139a82d49f39c))
* **Tearsheet web components:** control changes doesn't reflect in stories ([#6413](https://github.com/carbon-design-system/ibm-products/issues/6413)) ([84f6d14](https://github.com/carbon-design-system/ibm-products/commit/84f6d140d0476868a13b18ea886515d856bb0835))
* update to Carbon 11 compatible versions to latest ([#6437](https://github.com/carbon-design-system/ibm-products/issues/6437)) ([48d5c34](https://github.com/carbon-design-system/ibm-products/commit/48d5c34dca79a4b00fc69391a513431fa21295ee))





# [0.4.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/[email protected]...@carbon/[email protected]) (2024-12-04)

**Note:** Version bump only for package @carbon/ibm-products-web-components
Expand Down
4 changes: 2 additions & 2 deletions packages/ibm-products-web-components/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@carbon/ibm-products-web-components",
"description": "Carbon for IBM Products Web Components",
"version": "0.4.0",
"version": "0.5.0-rc.0",
"license": "Apache-2.0",
"main": "es/index.js",
"module": "es/index.js",
Expand Down Expand Up @@ -49,7 +49,7 @@
"wca": "web-component-analyzer analyze src --outFile custom-elements.json"
},
"dependencies": {
"@carbon/ibm-products-styles": "^2.51.0",
"@carbon/ibm-products-styles": "^2.52.0-rc.0",
"@carbon/styles": "1.70.0",
"@carbon/web-components": "2.18.0",
"lit": "^3.1.0"
Expand Down
30 changes: 30 additions & 0 deletions packages/ibm-products/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,36 @@
All notable changes to this project will be documented in this file.
See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.

# [2.56.0-rc.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/[email protected]...@carbon/[email protected]) (2024-12-09)


### Bug Fixes

* **APIKeyModal:** implement focus return to generate button ([#6440](https://github.com/carbon-design-system/ibm-products/issues/6440)) ([535e871](https://github.com/carbon-design-system/ibm-products/commit/535e87142413695c530952f7b314201c8a35becc))
* **APIKeyModal:** implement useFocus hook ([#6290](https://github.com/carbon-design-system/ibm-products/issues/6290)) ([4a92770](https://github.com/carbon-design-system/ibm-products/commit/4a92770d9179f6b59bfe18e53c998fdb51bd794a))
* **conditionBuilder:** issue fix and data correction ([#6421](https://github.com/carbon-design-system/ibm-products/issues/6421)) ([1f5b63e](https://github.com/carbon-design-system/ibm-products/commit/1f5b63ec428ddd2a2b2ee7c4153c83c2fff6a61c))
* **CreateTearsheet:** Dynamically disable/hide the experimentalSecondarySubmit button in CreateTearsheet ([#6412](https://github.com/carbon-design-system/ibm-products/issues/6412)) ([2eab4db](https://github.com/carbon-design-system/ibm-products/commit/2eab4db31164aed9f84c003466fce0bc74467ce3))
* **EmptyState:** empty states throws hydration errors in next js due to dynamic id ([#6508](https://github.com/carbon-design-system/ibm-products/issues/6508)) ([d5767e8](https://github.com/carbon-design-system/ibm-products/commit/d5767e8e9e5bc078d7324fbda71268a4d42d0bee))
* **FullPageError:** accessibility violations ([#6503](https://github.com/carbon-design-system/ibm-products/issues/6503)) ([3f45528](https://github.com/carbon-design-system/ibm-products/commit/3f45528cd037c0232c2699c18d8bf63a5da8891b))
* **side panel in react:** slideIn not working as expected ([#6501](https://github.com/carbon-design-system/ibm-products/issues/6501)) ([9d07dab](https://github.com/carbon-design-system/ibm-products/commit/9d07dab82cefd4046f65f8cac25d1d829f6d7c1a))
* **tearsheet:** address portalTarget type ([#6400](https://github.com/carbon-design-system/ibm-products/issues/6400)) ([a11d036](https://github.com/carbon-design-system/ibm-products/commit/a11d0364a5beaa3d018db559656c3d7806e1b484))
* update accessibility-checker version ([#6525](https://github.com/carbon-design-system/ibm-products/issues/6525)) ([d8c7051](https://github.com/carbon-design-system/ibm-products/commit/d8c70518087e7e41fdf1aa45cbbf692389058d56))
* update to Carbon 11 compatible versions to latest ([#6437](https://github.com/carbon-design-system/ibm-products/issues/6437)) ([48d5c34](https://github.com/carbon-design-system/ibm-products/commit/48d5c34dca79a4b00fc69391a513431fa21295ee))
* **useravatar:** accessibility issue and add avt complex state ([#6399](https://github.com/carbon-design-system/ibm-products/issues/6399)) ([4a70821](https://github.com/carbon-design-system/ibm-products/commit/4a70821b85688730a9d4484340da2517ee079db1))


### Features

* add utils section to storybook ([#6394](https://github.com/carbon-design-system/ibm-products/issues/6394)) ([711eb72](https://github.com/carbon-design-system/ibm-products/commit/711eb72ef00d1f1935fd0fcec9e0c0383dff53dc))
* **BreadcrumbWithOverflow:** adopt overflowMenuV12 and floating ui ([#6411](https://github.com/carbon-design-system/ibm-products/issues/6411)) ([f716852](https://github.com/carbon-design-system/ibm-products/commit/f716852c979a0b9556e853fad7e7a7774b4c6579))
* **coachmark:** Add default opening for not-stacked coachmarks ([#6516](https://github.com/carbon-design-system/ibm-products/issues/6516)) ([73ee693](https://github.com/carbon-design-system/ibm-products/commit/73ee693dda68bbbc0ccc6ed802b0efe8f528950e))
* Decouple lottie-web dependency from our repo ([#6477](https://github.com/carbon-design-system/ibm-products/issues/6477)) ([6b0a75b](https://github.com/carbon-design-system/ibm-products/commit/6b0a75ba4d15d7b2e640b4bb6992635ec3ab770c))
* **productive card:** floating ui for overflow menu ([#6395](https://github.com/carbon-design-system/ibm-products/issues/6395)) ([42a1362](https://github.com/carbon-design-system/ibm-products/commit/42a1362ad2ff4998f8286ed0698a82c4ec8ea552))





# [2.55.0](https://github.com/carbon-design-system/ibm-products/compare/@carbon/[email protected]...@carbon/[email protected]) (2024-12-04)

**Note:** Version bump only for package @carbon/ibm-products
Expand Down
6 changes: 3 additions & 3 deletions packages/ibm-products/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@carbon/ibm-products",
"description": "Carbon for IBM Products",
"version": "2.55.0",
"version": "2.56.0-rc.0",
"license": "Apache-2.0",
"main": "lib/index.js",
"module": "es/index.js",
Expand Down Expand Up @@ -81,7 +81,7 @@
"fs-extra": "^11.2.0",
"glob": "^10.3.10",
"jest": "^29.7.0",
"jest-config-ibm-cloud-cognitive": "^1.14.0",
"jest-config-ibm-cloud-cognitive": "^1.15.0-rc.0",
"jest-environment-jsdom": "^29.7.0",
"namor": "^1.1.2",
"npm-check-updates": "^16.14.12",
Expand All @@ -96,7 +96,7 @@
"dependencies": {
"@babel/runtime": "^7.23.9",
"@carbon/feature-flags": "^0.24.0",
"@carbon/ibm-products-styles": "^2.51.0",
"@carbon/ibm-products-styles": "^2.52.0-rc.0",
"@carbon/telemetry": "^0.1.0",
"@dnd-kit/core": "^6.0.8",
"@dnd-kit/modifiers": "^7.0.0",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ APIKeyDownloader.propTypes = {
/**
* body content for the downloader
*/
body: PropTypes.string.isRequired,
body: PropTypes.string,
/**
* aria-label for the download link
*/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ const defaultProps = {
copyButtonText: 'Copy',
copyIconDescription: 'Copy',
hasAPIKeyVisibilityToggle: true,
downloadBodyText:
helperText:
'This is your unique API key and is non-recoverable. If you lose this API key, you will have to reset it.',
downloadLinkText: 'Download as JSON',
downloadLinkLabel: 'Download API Key in Java Script File format',
Expand All @@ -74,8 +74,8 @@ const defaultProps = {
downloadFileType: 'json',
open: true,
closeButtonText: 'Close',
generateSuccessTitle: 'API key successfully created',
editSuccessTitle: 'API key successfully saved',
generateSuccessMessage: 'API key successfully created',
editSuccessMessage: 'API key successfully saved',
loadingText: 'Generating...',
modalLabel: 'An example of Generate API key',
};
Expand Down Expand Up @@ -301,7 +301,7 @@ const MultiStepTemplate = (args) => {
)}
{editSuccess && (
<div className={`${blockClass}__messaging`}>
Edited successfully
Edited successfully, API key successfully saved.
</div>
)}
</>
Expand Down Expand Up @@ -415,6 +415,7 @@ export const InstantGenerate = InstantTemplate.bind({});
InstantGenerate.args = {
...defaultProps,
apiKeyLabel: 'Unique API Key',
generateTitle: 'Generate an API key',
};

export const CustomGenerate = MultiStepTemplate.bind({});
Expand All @@ -428,6 +429,7 @@ CustomGenerate.args = {
savedAllResources: false,
savedResource: '',
savedPermissions: '',
generateTitle: 'Generate an API key',
};
CustomGenerate.parameters = {
docs: {
Expand Down Expand Up @@ -489,6 +491,7 @@ CustomEdit.args = {
savedPermissions: 'Read only',
editing: true,
editButtonText: 'Save API key',
generateTitle: 'Save an API key',
};
CustomEdit.parameters = {
docs: {
Expand Down
Loading

0 comments on commit 29763cd

Please sign in to comment.