feat: 14595-update-ally-test-tags #14913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
approved these changes
Oct 16, 2023
tay1orjones
added
status: ready to merge 🎉
and removed
status: one more review 👀
labels
This was referenced Oct 16, 2023
tw15egan
approved these changes
Oct 16, 2023
|
@andreancardona seems like a few tests are timing out |
|
@andreancardona seems like there is a merge conflict now as well |
…595-update-ally-test-tags
|
Resolved 👍 |
|
This may need the sharding update in #14915 merged first if the tests continue to timeout here. |
|
@andreancardona there's a couple conflicts here - once resolved, I think this will be good to go. I solved the progress indicator errors in #14915 |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Merged
via the queue into
carbon-design-system:main
with commit Nov 17, 2023
1488f59
18 checks passed
danoro96
pushed a commit
to danoro96/carbon
that referenced
this pull request
Jan 18, 2024
Co-authored-by: TJ Egan <[email protected]> Co-authored-by: Guilherme Datilio Ribeiro <[email protected]> Co-authored-by: Taylor Jones <[email protected]> Co-authored-by: Taylor Jones <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14595
Update
avttest naming conventions to use the following: