Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button guidance PR #4409

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Button guidance PR #4409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
390274a
button_pr
alina-jacob-ibm Dec 13, 2024
7fecafe
chore: yarn format
alisonjoseph Dec 13, 2024
a66a661
fix: update icon to StopOutline
alisonjoseph Dec 13, 2024
df020bc
chore: encode characters
alisonjoseph Dec 13, 2024
a93f016
update_1
alina-jacob-ibm Dec 19, 2024
6505681
Merge branch 'main' into button_pr
alina-jacob Dec 19, 2024
6ad3f5f
chore:format
alisonjoseph Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added ...pages/components/button/images/button-style-danger-ghost-interactive-states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/components/button/images/button-style-danger-ghost.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...ges/components/button/images/button-style-danger-primary-interactive-states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/button/images/button-style-danger-primary.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...es/components/button/images/button-style-danger-tertiary-interactive-states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/components/button/images/button-style-danger-tertiary.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed src/pages/components/button/images/button-style-danger.png
View file
Open in desktop
Binary file not shown.
Binary file removed src/pages/components/button/images/button-style-ghost+icon-only.png
View file
Open in desktop
Binary file not shown.
Binary file added ...es/components/button/images/button-style-ghost-icon-only-interactive-states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/button/images/button-style-ghost-icon-only.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/button/images/button-style-ghost-interactive-states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/components/button/images/button-style-ghost.png
100755 → 100644
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added .../components/button/images/button-style-primary-icon-only-interactive-states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/button/images/button-style-primary-icon-only.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/button/images/button-style-primary-interactive-states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/components/button/images/button-style-primary.png
100755 → 100644
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...omponents/button/images/button-style-secondary-icon-only-interactive-states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/button/images/button-style-secondary-icon-only.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/button/images/button-style-secondary-interactive-states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/components/button/images/button-style-secondary.png
100755 → 100644
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/components/button/images/button-style-sizes.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/button/images/button-style-structure-button-groups.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/button/images/button-style-structure-ghost.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified src/pages/components/button/images/button-style-structure.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...components/button/images/button-style-tertiary-icon-only-interactive-states.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added src/pages/components/button/images/button-style-tertiary-icon-only.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button-style-tertiary-interactive-states.png
View file
Open in desktop
Binary file modified src/pages/components/button/images/button-style-tertiary.png
100755 → 100644
View file
Open in desktop
Binary file added src/pages/components/button/images/button-usage-RTL.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button-usage-ub-inline-loading.gif
View file
Open in desktop
Binary file added src/pages/components/button/images/button-usage-ub-validation.gif
View file
Open in desktop
Binary file removed src/pages/components/button/images/button_usage_1.png
View file
Open in desktop
Diff not rendered.
Binary file modified src/pages/components/button/images/button_usage_10.png
View file
Open in desktop
Binary file modified src/pages/components/button/images/button_usage_11.png
View file
Open in desktop
Binary file modified src/pages/components/button/images/button_usage_12.png
View file
Open in desktop
Binary file modified src/pages/components/button/images/button_usage_13.png
View file
Open in desktop
Binary file modified src/pages/components/button/images/button_usage_14.png
View file
Open in desktop
Binary file modified src/pages/components/button/images/button_usage_15.png
View file
Open in desktop
Binary file removed src/pages/components/button/images/button_usage_15_test.png
View file
Open in desktop
Diff not rendered.
Binary file modified src/pages/components/button/images/button_usage_2.png
View file
Open in desktop
Binary file modified src/pages/components/button/images/button_usage_26.png
View file
Open in desktop
Binary file modified src/pages/components/button/images/button_usage_27.png
View file
Open in desktop
Binary file modified src/pages/components/button/images/button_usage_3.png
View file
Open in desktop
Binary file removed src/pages/components/button/images/button_usage_30.png
View file
Open in desktop
Diff not rendered.
Binary file removed src/pages/components/button/images/button_usage_31.png
View file
Open in desktop
Diff not rendered.
Binary file modified src/pages/components/button/images/button_usage_5.png
View file
Open in desktop
Binary file modified src/pages/components/button/images/button_usage_6.png
View file
Open in desktop
Binary file removed src/pages/components/button/images/button_usage_7.png
View file
Open in desktop
Diff not rendered.
Binary file modified src/pages/components/button/images/button_usage_8.png
View file
Open in desktop
Binary file removed src/pages/components/button/images/button_usage_8_test.png
View file
Open in desktop
Diff not rendered.
Binary file modified src/pages/components/button/images/button_usage_9.png
View file
Open in desktop
Binary file removed src/pages/components/button/images/button_usage_9_test.png
View file
Open in desktop
Diff not rendered.
Binary file added src/pages/components/button/images/button_usage_button_with_icon_1.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_button_with_icon_10.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_button_with_icon_11.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_button_with_icon_12.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_button_with_icon_13.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_button_with_icon_2.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_button_with_icon_3.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_button_with_icon_4.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_button_with_icon_5.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_button_with_icon_6.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_button_with_icon_7.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_button_with_icon_8.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_button_with_icon_9.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_danger_ghost.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_danger_primary.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_danger_tertiary.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_ghost_1.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_ghost_2.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_ghost_3.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_ghost_4.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_ghost_5.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_ghost_6.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_ghost_7.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_ghost_8.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_ghost_9.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_icon_only_button_1.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_icon_only_button_2.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_icon_only_button_3.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_icon_only_button_4.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_icon_only_button_5.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_icon_only_button_6.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_overflow_1.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_overflow_2.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_primary_1.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_primary_2.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_primary_3.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_secondary_1.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_secondary_2.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_secondary_3.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_tertiary_1.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_tertiary_2.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_tertiary_3.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_tertiary_4.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_tertiary_5.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_tertiary_6.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_tertiary_7.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_ub_focus.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_ub_interaction.png
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overlay of this button looks off. Maybe try it with the multiply effect.

Binary file added src/pages/components/button/images/button_usage_ub_loading_3.png
View file
Open in desktop
Binary file added src/pages/components/button/images/button_usage_ub_validation_4.png
View file
Open in desktop
591 changes: 431 additions & 160 deletions src/pages/components/button/style.mdx
View file
Open in desktop

Large diffs are not rendered by default.

1,008 changes: 853 additions & 155 deletions src/pages/components/button/usage.mdx
View file
Open in desktop

Large diffs are not rendered by default.

Loading