Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(docs) Carbon Labs on core #4383

Merged
merged 7 commits into from
Dec 11, 2024
Merged

(docs) Carbon Labs on core #4383

merged 7 commits into from
Dec 11, 2024

Conversation

aagonzales
Copy link
Member

@aagonzales aagonzales commented Dec 4, 2024 •
edited
Loading

Closes #4181

Changelog

Changed

  • Added "Carbon Labs" section on "Contributing/Getting Started" page
  • Added "Carbon Labs" section under "Discovery" on PDLC page

@vercel Vercel
Copy link

vercel bot commented Dec 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 11, 2024 6:25pm

@aagonzales aagonzales marked this pull request as ready for review December 5, 2024 23:23
@aagonzales aagonzales requested review from a team as code owners December 5, 2024 23:23
@aagonzales
Copy link
Member Author

@alisonjoseph Could you help me figure out why my build is failing?

@alisonjoseph
Copy link
Member

@aagonzales should be good now, I pulled it down and ran yarn format

@aagonzales
Copy link
Member Author

Thank you! I'll remember to try that first next time

laurenmrice
laurenmrice approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Just a small comment on the PDLC > Discovery criteria > "Added to Carbon Labs" section. Wondering if the heading here should instead say "Add to Carbon Labs" or "Adding to Carbon Labs". It's up to you though!

@kodiakhq kodiakhq bot merged commit da98238 into carbon-design-system:main Dec 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurenmrice laurenmrice laurenmrice approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DoD]: Carbon Labs added to IA
3 participants
@aagonzales @alisonjoseph @laurenmrice