-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(pagination): update a11y tab bugs for pagination nav #4381
Merged
alisonjoseph
merged 10 commits into
carbon-design-system:main
from
laurenmrice:image-fix-icons-page
Dec 11, 2024
Merged
docs(pagination): update a11y tab bugs for pagination nav #4381
alisonjoseph
merged 10 commits into
carbon-design-system:main
from
laurenmrice:image-fix-icons-page
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
alisonjoseph
approved these changes
Dec 3, 2024
tay1orjones
approved these changes
Dec 3, 2024
tay1orjones
added
status: one more review 👀
and removed
status: ready for review 👀
labels
Dec 3, 2024
thyhmdo
reviewed
Dec 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! just 2 comments
thyhmdo
reviewed
Dec 5, 2024
@thyhmdo Made the changes! |
thyhmdo
approved these changes
Dec 6, 2024
laurenmrice
added
status: ready to merge 🎉
and removed
status: visual review 🔍
status: one more review 👀
labels
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4351
This PR updates a few image bugs and content sections to reflect accurate accessibility information in regards to the pagination navs interactions.
Changed