Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pagination): update a11y tab bugs for pagination nav #4381

Merged

Conversation

laurenmrice
Copy link
Member

Closes #4351

This PR updates a few image bugs and content sections to reflect accurate accessibility information in regards to the pagination navs interactions.


Changed

  • Changed images with correct annotations.
  • Changed some sections of content to reflect correct annotations.

@laurenmrice laurenmrice requested a review from thyhmdo December 3, 2024 15:56
@laurenmrice laurenmrice requested review from a team as code owners December 3, 2024 15:56
Copy link

vercel bot commented Dec 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ❌ Failed (Inspect) Dec 9, 2024 6:28pm

Copy link
Member

@thyhmdo thyhmdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! just 2 comments

src/pages/components/pagination/accessibility.mdx Outdated Show resolved Hide resolved
@laurenmrice
Copy link
Member Author

@thyhmdo Made the changes!

@alisonjoseph alisonjoseph merged commit db45c08 into carbon-design-system:main Dec 11, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Pagination] Fixes in a11y tab images
4 participants