Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(issue-triage-area): workflow cleanup #4379

Merged
merged 4 commits into from
Dec 9, 2024
Merged

fix(issue-triage-area): workflow cleanup #4379

merged 4 commits into from
Dec 9, 2024

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Nov 26, 2024 •
edited
Loading

fix issue triage area repo

Changed

  • update to use project id and project number
  • remove -r

@ariellalgilmore ariellalgilmore requested review from a team as code owners November 26, 2024 18:01
@vercel Vercel
Copy link

vercel bot commented Nov 26, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 9, 2024 8:46pm

kennylam
kennylam previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ariellalgilmore ariellalgilmore marked this pull request as draft November 26, 2024 18:36
@kennylam kennylam dismissed their stale review November 26, 2024 18:59

Further testing needed

@ariellalgilmore ariellalgilmore changed the title fix(issue-triage-area): workflow remove -r fix(issue-triage-area): workflow cleanup Dec 9, 2024
@ariellalgilmore ariellalgilmore marked this pull request as ready for review December 9, 2024 20:35
tay1orjones
tay1orjones approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tay1orjones tay1orjones enabled auto-merge (squash) December 9, 2024 20:40
@tay1orjones tay1orjones disabled auto-merge December 9, 2024 20:40
@ariellalgilmore ariellalgilmore enabled auto-merge (squash) December 9, 2024 20:41
@tay1orjones
Copy link
Member

This doesn't need a visual review

@tay1orjones tay1orjones removed the request for review from Kritvi-bhatia17 December 9, 2024 20:42
@tay1orjones tay1orjones disabled auto-merge December 9, 2024 20:43
@tay1orjones tay1orjones merged commit ae42036 into carbon-design-system:main Dec 9, 2024
6 of 7 checks passed
@ariellalgilmore ariellalgilmore deleted the workflow-update branch December 9, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@alisonjoseph alisonjoseph alisonjoseph approved these changes

@kennylam kennylam kennylam left review comments

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/developers-system-reviewers

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ariellalgilmore @tay1orjones @kennylam @alisonjoseph @annawen1