[Inline loading] Updated text size and states #4374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
laurenmrice
requested changes
Nov 25, 2024
There was a problem hiding this comment.
- This image needs the borders on the edges so the background doesn't blend in with the website page background.
- Could you try to vertically align the labels of these and visually center them within each section? Would be good to update the Style image to this too.
- The divider borders look like they are two different colors. They should be the border-subtle-01 color for the gray 10 theme.
- The inline loading label should be $body-compact-01.
guidari
approved these changes
Dec 4, 2024
laurenmrice
requested changes
Dec 4, 2024
There was a problem hiding this comment.
Hey @thyhmdo ! The dividers here need to be the $border-subtle-01 in the Gray 10 theme. Right now they are using the White theme and are a bit dark. It should be changed on both the Usage and Style tab. Other than that it looks good!
laurenmrice
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #https://github.com/orgs/carbon-design-system/projects/39/views/13?filterQuery=sprint%3A%22%40next%22+design&pane=issue&itemId=80437243&issue=carbon-design-system%7Ccarbon-website%7C4271
New