Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added vertical tab variant #4221

Merged
merged 3 commits into from
Sep 11, 2024
Merged

fix: added vertical tab variant #4221

merged 3 commits into from
Sep 11, 2024

Conversation

riddhybansal
Copy link
Contributor

Closes #4160

Added vertical variant to tabs

Changelog

New

Added vertical variant to tabs

Testing

Go to Tabs and check if there is a vertical variant in livedemo and it works as intended

Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 11:45am

Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @riddhybansal! I am able to see the "Vertical" option under the Tabs' Live demo, but I'm unsure about the output it’s showing. The output in the Live demo doesn’t seem to match what we have in our [React Storybook](https://react.carbondesignsystem. Could you please confirm that?

Live demo
Screenshot 2024-08-28 at 3 07 16 AM

React storybook
Screenshot 2024-08-28 at 3 06 57 AM

Copy link
Member

@alina-jacob alina-jacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Riddhi! 🚀

@riddhybansal
Copy link
Contributor Author

Hi @riddhybansal! I am able to see the "Vertical" option under the Tabs' Live demo, but I'm unsure about the output it’s showing. The output in the Live demo doesn’t seem to match what we have in our [React Storybook](https://react.carbondesignsystem. Could you please confirm that?

Live demo
Screenshot 2024-08-28 at 3 07 16 AM

React storybook
Screenshot 2024-08-28 at 3 06 57 AM

Hi @Kritvi-bhatia17 I could see the same in preview, not sure whats happening for you.

@Kritvi-bhatia17 Kritvi-bhatia17 self-requested a review August 28, 2024 11:20
Copy link
Contributor

@Kritvi-bhatia17 Kritvi-bhatia17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @riddhybansal! I am able to see the "Vertical" option under the Tabs' Live demo, but I'm unsure about the output it’s showing. The output in the Live demo doesn’t seem to match what we have in our [React Storybook](https://react.carbondesignsystem. Could you please confirm that?

Live demo
Screenshot 2024-08-28 at 3 07 16 AM

React storybook
Screenshot 2024-08-28 at 3 06 57 AM

Hi @Kritvi-bhatia17 I could see the same in preview, not sure whats happening for you.

Hi @riddhybansal , thanks for confirming that. It is working fine in another browser, LGTM 🎉

Copy link
Member

@alisonjoseph alisonjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs to also get added to the demo on the code page.

@alisonjoseph alisonjoseph merged commit 5489d40 into main Sep 11, 2024
7 checks passed
@alisonjoseph alisonjoseph deleted the add_vertical_tab_variant branch September 11, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tabs] Add vertical variant to tab live demo
4 participants