Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs (notifications): usage and style guidance for Callout #4218

Merged
merged 13 commits into from
Nov 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
24 changes: 22 additions & 2 deletions src/pages/components/notification/style.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ capitalized. Notification titles should be concise and to the point.

## Structure

### Toast notification
### Toast

| Element | Property | px / rem | Spacing token |
| ------------ | ------------------------ | -------- | ------------- |
Expand All @@ -91,7 +91,7 @@ capitalized. Notification titles should be concise and to the point.
Structure and spacing measurements for a toast notification | px / rem
</Caption>

### Inline notification
### Inline

The width of an _inline notification_ will vary based on content or layout.

Expand All @@ -114,3 +114,23 @@ The width of an _inline notification_ will vary based on content or layout.
<Caption>
Structure and spacing measurements for an inline notification | px / rem
</Caption>

### Callout

The width of a _callout_ will vary based on content or layout.

| Element | Property | px / rem | Spacing token |
| ------------ | --------------------------- | --------- | ------------- |
| Callout | min-height | 48 / 3 | `$spacing-09` |
| | border-left | 3px ||
| Details | margin-left, margin-right | 16 / 1 | `$spacing-05` |
| Text-wrapper | padding-top, padding-bottom | 12 / 0.75 | `$spacing-04` |
| Icon | margin-right | 16 / 1 | `$spacing-05` |

<div className="image--fixed">
benjamin-kurien marked this conversation as resolved.
Show resolved Hide resolved

![Structure and spacing for a callout | px / rem ](images/notification-style-callout.png)

</div>

<Caption>Structure and spacing for a callout | px / rem</Caption>
Loading
Loading