-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(avt): a11y status page and a11y status table component #3866
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Looking great!! Just a few minor things This is on me, but I'm looking to change the text to:
Change to with the lower case of "tags" I noticed that this one variant page "View all component..." link takes me to the "Accessibility tag status" table instead of all the "All component accessibility status" section. |
@thyhmdo just pushed a fix. The anchor links weren't working correctly because of the tooltip within the title. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Awesome work! 🚀
@alisonjoseph One question. When I try to access this component "Aspect Ratio" I get an 404. I know it is because we don't have a page in the website for the component so the error is totally right. But just to make sure, should we cover that somehow or that's okay? |
@guidari ah good catch, I'll fix that, Going to have it link to the Grid docs page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed @andreancardona |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
@thyhmdo Obviously kinda late for this comment, but I was a little surprised to see these appearing at the top of the accessibility tab. I did want to flag that it's a little odd that these are implemented with an H3, since the page structure is now wonky: I don't think the status deserves an H2 -- its not on par with the other typical H2s:
IMO, it conceptually probably makes the most sense under Development considerations. |
Hey @mbgower thanks for the feedback and noted. We probably can change the order of it in the future. We also moved away from the margin space because of the condensed space, this will soon be reflected on tiles on the Usage tab work instead. |
Closes #3851
Closes #3848
Closes #3849
Building off work started in #3735 (should be able to close that now)
Changelog
/components/overview/accessibility-status
A11yStatus
componentA11ySTatusTag
componentA11yStatus
component to all component a11y pagesTesting
New page
Component filtered on individual component a11y pages