Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: contributing code and design new content #3757

Merged
merged 13 commits into from
Oct 6, 2023
Merged

docs: contributing code and design new content #3757

merged 13 commits into from
Oct 6, 2023

Conversation

aubrey-oneal
Copy link
Member

@aubrey-oneal aubrey-oneal commented Sep 27, 2023 •
edited
Loading

Closes #3719

Changelog

New screen capture videos

  • code-contribution.mp4
  • design-contribution.mp4
  • edit-this-page-contribution.mp4
  • indline-edit.mp4

New pages

  • Code
  • Design

Pages Removed

  • Bugs and request
  • Components
  • Patterns
  • Icons
  • Pictogram
  • Add ons

@aubrey-oneal aubrey-oneal requested review from a team as code owners September 27, 2023 17:35
@vercel
Copy link

vercel bot commented Sep 27, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbondesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 6, 2023 3:40pm

andreancardona
andreancardona approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@andreancardona andreancardona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment / question - otherwise everything looks good!

@vercel
Copy link

vercel bot commented Oct 4, 2023

@aubrey-oneal is attempting to deploy a commit to the Carbon Design System Team on Vercel.

A member of the Team first needs to authorize it.

laurenmrice
laurenmrice previously requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@laurenmrice laurenmrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @aubrey-oneal ! Just found a couple typos:

src/pages/contributing/code.mdx Outdated Show resolved Hide resolved
src/pages/contributing/design.mdx Outdated Show resolved Hide resolved
src/pages/contributing/design.mdx Outdated Show resolved Hide resolved
src/pages/contributing/design.mdx Outdated Show resolved Hide resolved
src/pages/contributing/design.mdx Outdated Show resolved Hide resolved
src/pages/contributing/design.mdx Outdated Show resolved Hide resolved
jeanservaas
jeanservaas requested changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@jeanservaas jeanservaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just had a couple of comments to shorten some of the titles and also be specific about which office hours to attend on the code and design tabs.

src/pages/contributing/code.mdx Outdated Show resolved Hide resolved
src/pages/contributing/code.mdx Outdated Show resolved Hide resolved
src/pages/contributing/design.mdx Outdated Show resolved Hide resolved
src/pages/contributing/design.mdx Outdated Show resolved Hide resolved
src/pages/contributing/design.mdx Outdated Show resolved Hide resolved
@aubrey-oneal aubrey-oneal dismissed laurenmrice’s stale review October 6, 2023 16:19

Jeannie did a second design review so I think we are all good!

@aubrey-oneal aubrey-oneal merged commit 175ba94 into carbon-design-system:main Oct 6, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeanservaas jeanservaas jeanservaas approved these changes

@andreancardona andreancardona andreancardona approved these changes

@alisonjoseph alisonjoseph Awaiting requested review from alisonjoseph alisonjoseph was automatically assigned from carbon-design-system/developers-system

@tw15egan tw15egan Awaiting requested review from tw15egan tw15egan was automatically assigned from carbon-design-system/developers-system

@kingtraceyj kingtraceyj Awaiting requested review from kingtraceyj kingtraceyj is a code owner automatically assigned from carbon-design-system/design

@laurenmrice laurenmrice Awaiting requested review from laurenmrice

Assignees
No one assigned
Labels
status: ready for review 👀
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Website docs: Contributing code page
4 participants
@aubrey-oneal @andreancardona @jeanservaas @laurenmrice