Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Tertiary Button BorderOopacity onPress #173

Closed
wants to merge 1 commit into from

Conversation

joseio
Copy link

@joseio joseio commented Feb 7, 2024

Problem Solved

  • Currently, when a tertiary button is pressed, the 1px border from it is removed. This may cause the other elements in the page to shift by 1px (as shown in this this video recording)

What was Done

  • Changed border opacity to 0 to hide the 1px border when a tertiary button is pressed

How to Test

  • Click on the tertiary button and ensure that the border disappears without shifting other elements by 1px

Tertiary button shifted page by 1 pixel onPress. Changing border opacity.
@joseio joseio requested a review from dabrad26 as a code owner February 7, 2024 14:26
Copy link

github-actions bot commented Feb 7, 2024

DCO Assistant Lite bot: Thanks for your submission! We ask that you sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text:


I have read the DCO document and I hereby sign the DCO.


joseio seems not to be a GitHub user. You need a GitHub account to be able to sign the DCO. If you have already a GitHub account, please add the email address used for this commit to your account.
You can retrigger this bot by commenting recheck in this Pull Request

@joseio
Copy link
Author

joseio commented Feb 7, 2024

I have read the DCO document and I hereby sign the DCO.

@joseio
Copy link
Author

joseio commented Feb 7, 2024

recheck

Copy link
Member

@dabrad26 dabrad26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ends up breaking the design of high contrast items (that maintain a border in pressed. I added the tertiary type to the keep border width logic. And that seems to fix all

Added this change here #174

@dabrad26 dabrad26 closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants