Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bugs from Carbon migration from GHE #154

Merged
merged 2 commits into from
Sep 20, 2023
Merged

fix: bugs from Carbon migration from GHE #154

merged 2 commits into from
Sep 20, 2023

Conversation

dabrad26
Copy link
Member

@dabrad26 dabrad26 commented Sep 19, 2023

Closes #114 (Tooltip icon colors)
Closes #115 (Menu/Dropdown icon support and max height props)
Closes #116 (FormItem left render toggle/checkbox)
Closes #117 (Toggle Spacing issues)
Closes #131 (Divider for Menu/Dropdown items)
Closes #132 (ActionSheet divider and full bleed)
Closes #121 (Pagination styling)
Closes #120 (Warning state for Text based input)
Closes #122 (Do not show state change for Navigation if no events)
Closes #126 (Header FormItem style fixes)
Closes #125 (Full bleed text spacing)

See each ticket for final implementation and comments

@dabrad26
Copy link
Member Author

@hsu022210
@ycliu0953
@theurbanspectacle

Could you review?

Copy link

@theurbanspectacle theurbanspectacle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@dabrad26 dabrad26 added this pull request to the merge queue Sep 20, 2023
Merged via the queue into main with commit 920c699 Sep 20, 2023
@dabrad26 dabrad26 deleted the bugs-919 branch September 20, 2023 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants