Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tablecell section (FormItem type header) design update #126

Closed
Kwadwo-Asamoah mannequin opened this issue May 17, 2023 · 1 comment · Fixed by #154
Closed

Tablecell section (FormItem type header) design update #126

Kwadwo-Asamoah mannequin opened this issue May 17, 2023 · 1 comment · Fixed by #154
Assignees
Labels
Review Pending code review before closing.

Comments

@Kwadwo-Asamoah
Copy link
Mannequin

Kwadwo-Asamoah mannequin commented May 17, 2023

In the Gray 10 Theme Mobile-Carbon Design System figma file there is a component called Tablecell section (Which we call Formitem type header in carbon react native library). Design here:
https://www.figma.com/file/O3KSDu2TWpMaazGkgsKqLA/(Beta)-Gray-10-Theme-Mobile---Carbon-Design-System?type=design&node-id=14455-242397&t=9tBXmB1SKwRvXH7Q-4

  • Form item type header should be 14px rather than 16px in text size
  • Form item type header description should be 8px of top padding

Library current
image

Figma
image

If there is another way to render these items that we are not aware of please let us know. Thank you

If you have design questions you can slack @lisa or @rjgervacio @juanencalada
If you need any additional information you can slack @kwadwo

@David-Bradshaw

@dabrad26
Copy link
Member

Changed header to heading-compact-01 and added 4px top padding to header description.

Screenshot 2023-09-19 at 14 13 20

@dabrad26 dabrad26 self-assigned this Sep 19, 2023
@dabrad26 dabrad26 added the Review Pending code review before closing. label Sep 19, 2023
@dabrad26 dabrad26 moved this from Todo to Review in Carbon for React Native Sep 19, 2023
@github-project-automation github-project-automation bot moved this from Todo to Done in Carbon for React Native Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review Pending code review before closing.
Projects
Development

Successfully merging a pull request may close this issue.

1 participant