-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feedback-container): adding feedback-container component #34
feat(feedback-container): adding feedback-container component #34
Conversation
❌ Deploy Preview for carbon-for-ai failed.
|
DCO Assistant Lite bot: Thanks for your submission! We ask that you all sign our Developer Certificate of Origin before we can accept your contribution. You can sign the DCO by adding a comment below using this text: I have read the DCO document and I hereby sign the DCO. 0 out of 2 committers have signed the DCO. |
@priyanshu891 looks like you need to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have some questions on if these components would live in the chat package instead and the placement of the styles
@@ -0,0 +1,67 @@ | |||
/** | |||
* @license |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these components all be put in the Chat
package instead?
* More on how to set up stories at: https://storybook.js.org/docs/web-components/writing-stories/introduction | ||
*/ | ||
export default { | ||
title: 'Components/Feedback container/Feedback container', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we put these components in the chat
package, we probably want to change the storybook title here to
Components/Chat/Feedback container
so that they are all listed under the Chat
component in storybook
@@ -0,0 +1,37 @@ | |||
{ | |||
"name": "@carbon-labs/feedback", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may not be needed if we're placing the components within the chat
package
import '@carbon/web-components/es/components/button/index.js'; | ||
|
||
export class FeedbackContainer extends LitElement { | ||
static styles = css` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can these styles be separated out into its own file? (see extended-button component for example)
opened new PR |
Closes #
Initial Setup of Feedback Container component
Changelog
New
Changed
Removed
Testing / Reviewing
N/A