Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(storybook): react boilerplate #324

Merged
merged 18 commits into from
Dec 11, 2024

Conversation

Gururajj77
Copy link
Contributor

@Gururajj77 Gururajj77 commented Dec 5, 2024

Closes #263

adds react boilerplate example

Changelog

New

  • packages/react folder
  • an example component package built with @carbon/react
  • snapshot and unit tests with Jest for example component
  • React storybook

Testing / Reviewing

CI should pass

Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for carbon-labs ready!

Name Link
🔨 Latest commit 5da4b22
🔍 Latest deploy log https://app.netlify.com/sites/carbon-labs/deploys/6759a67d99b2ad0008f4cc30
😎 Deploy Preview https://deploy-preview-324--carbon-labs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@annawen1 annawen1 changed the title story: react boilerplate chore(storybook): react boilerplate Dec 9, 2024
annawen1
annawen1 previously approved these changes Dec 9, 2024
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, some minor clean up

Comment on lines 29 to 36
You can build an accordion using a combination of the `Accordion` and
`AccordionItem` components. The `Accordion` components accepts a list of
`AccordionItem` components as `children` and each `AccordionItem` is responsible
for displaying the accordion's heading and panel content.

You can configure the accordion item's heading using the `title` prop.
Everything you pass in as a child of `AccordionItem` will be rendered in the
accordion's panel.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can probably populate with generate Button docs here

packages/react/public/manifest.json Outdated Show resolved Hide resolved
packages/react/README.md Outdated Show resolved Hide resolved
packages/react/.gitignore Show resolved Hide resolved
@Gururajj77 Gururajj77 marked this pull request as ready for review December 10, 2024 18:53
@annawen1 annawen1 dismissed their stale review December 11, 2024 14:36

need to address ci-checks

@annawen1 annawen1 merged commit 1c1fa4d into carbon-design-system:main Dec 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carbon Labs: Add react component boilerplate example
2 participants