-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(styles): restore use of globals/imports.scss #12175
Conversation
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This did nothing. |
The components most impacted in the percy review: Locale ModalComponent fails grid alignment in both cases. Expressive ModalComponent fails grid alignment in both cases. Card Section SimpleComponent fails grid alignment in both cases. QuoteComponent is improved by this PR Link List SectionComponent is improved by this PR |
|
Chatted with @andy-blum — we are good with everything here today, with the caveat that Card Section will get a little more tweaking for its grid. |
Description
the carbon reset has all items box-sizing set to inherit. this changes that to border box and is intended mainly to see what shifts in Percy