fix(cta): cause ctas to only respond to relevant video events #12169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4olivei
requested review from
bruno-amorim,
marcelojcs,
andy-blum and
Valentin-Sorin-Nicolae
and removed request for
a team
m4olivei
added
the
test: CDN preview
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Deploy preview created for package Built with commit: c4138e4493b59f4f54d8b5f346e04f03050e8061 |
andy-blum
approved these changes
Dec 18, 2024
|
Hey there! This issue/pull request was referenced in recently released v2.16.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #12168 in some build environments.
Related Ticket(s)
ADCMS-6749
Description
Fixes an issue where cta components would listen for any video fetch event and respond by putting the title into its rendered output, even though the video request came from another unrelated component.
Here is a branch of
carbon-demothat uses this PR's deploy preview to show the fix: https://github.com/m4olivei/carbon-demo/tree/video-text-ctaChangelog
Changed