fix(toc): remove implicit top and bottom padding for TOC #12144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4olivei
requested review from
bruno-amorim,
marcelojcs,
andy-blum and
Valentin-Sorin-Nicolae
and removed request for
a team
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
bruno-amorim
approved these changes
Dec 4, 2024
andy-blum
added
the
Ready to merge
andy-blum
approved these changes
Dec 4, 2024
andy-blum
pushed a commit
that referenced
this pull request
Dec 4, 2024
### Related Ticket(s) [ADCMS-7171](https://jsw.ibm.com/browse/ADCMS-7171) ### Description Removes the top and bottom implicit padding on the TOC contents in the shadow root. ### Changelog **Changed** - Removes the internal top and bottom padding from TOC contents to leave to adopter as in v1 <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Merged
|
Hey there! This issue/pull request was referenced in recently released v2.16.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
ADCMS-7171
ADCMS-7077
Description
Removes the top and bottom implicit padding on the TOC contents in the shadow root.
Changelog
Changed