Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card group item inverse color scheme #12138

Conversation

Valentin-Sorin-Nicolae
Copy link
Contributor

Related Ticket(s)

Closes #12080

Description

Figma Specs for inverse cards

Expected:
378000813-1c06f292-1c05-4500-a1a9-891e86774515

Actual:
378000836-5cccfcaa-5c6b-43ac-b3dd-7fb0b0fb2be6

Component(s) impacted

c4d-card-group-item, potentially other card elements

Changelog

Inverse color-scheme knob added to storybook.

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit 45a8358
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/6753598453da5b0008bd188f
😎 Deploy Preview https://deploy-preview-12138--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 2, 2024

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 3e862ca
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/6750ca06477c7f00089c69d8
😎 Deploy Preview https://deploy-preview-12138--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@andy-blum andy-blum added adopter: AEM used when component or pattern will be used by this adopter priority: high and removed adopter: AEM used when component or pattern will be used by this adopter labels Dec 3, 2024
@andy-blum andy-blum marked this pull request as ready for review December 4, 2024 19:33
@andy-blum andy-blum requested a review from a team as a code owner December 4, 2024 19:33
@andy-blum andy-blum requested review from m4olivei, bruno-amorim, marcelojcs and andy-blum and removed request for a team December 4, 2024 19:33
@andy-blum andy-blum changed the base branch from main to release/v2.16.0 December 5, 2024 13:13
@m4olivei m4olivei force-pushed the card-group-item-inverse-color-scheme branch from 3e862ca to a1b781e Compare December 5, 2024 17:55
@Valentin-Sorin-Nicolae
Copy link
Contributor Author

Great work @m4olivei, it's looking good now. I wonder if Add CTA card: should be inverse also or not? Because it's not right now.

@m4olivei m4olivei added the Ready to merge Label for the pull requests that are ready to merge label Dec 6, 2024
@m4olivei m4olivei removed the Ready to merge Label for the pull requests that are ready to merge label Dec 6, 2024
@m4olivei
Copy link
Contributor

m4olivei commented Dec 6, 2024

Great work @m4olivei, it's looking good now. I wonder if Add CTA card: should be inverse also or not? Because it's not right now.

Thanks @Valentin-Sorin-Nicolae ! Nice call out. I've made that update in 45a8358

@andy-blum andy-blum added the Ready to merge Label for the pull requests that are ready to merge label Dec 6, 2024
@kodiakhq kodiakhq bot merged commit 3616719 into carbon-design-system:release/v2.16.0 Dec 6, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[card-group-item]: color-scheme doesn't work correctly
3 participants