Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(footer): adjustments to adjunct links visibility #12136

Merged
merged 4 commits into from
Nov 29, 2024
Merged

fix(footer): adjustments to adjunct links visibility #12136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
70552f1
fix(footer): adjustments to adjunct links visibility
m4olivei Nov 29, 2024
07671d2
fix(footer): remove testing code
m4olivei Nov 29, 2024
856ce37
fix(footer): remove unused variable
m4olivei Nov 29, 2024
632a925
Merge branch 'main' into fix/adjunct-links-visibility
m4olivei Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/styles/scss/components/footer/_footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@
@include make-container;
}
}
.#{$prefix}--adjunct-links__container--hidden {
.#{$c4d-prefix}--adjunct-links__container--hidden {
display: none;
}
}
Expand Down
46 changes: 26 additions & 20 deletions packages/web-components/src/components/footer/legal-nav.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
*/

import { LitElement, html } from 'lit';
import { property, query } from 'lit/decorators.js';
import { property, query, state } from 'lit/decorators.js';
import { classMap } from 'lit/directives/class-map.js';
import { ifDefined } from 'lit/directives/if-defined.js';
import settings from '@carbon/ibmdotcom-utilities/es/utilities/settings/settings.js';
Expand All @@ -17,7 +17,7 @@ import StableSelectorMixin from '../../globals/mixins/stable-selector';
import styles from './footer.scss';
import { carbonElement as customElement } from '@carbon/web-components/es/globals/decorators/carbon-element.js';

const { prefix, stablePrefix: c4dPrefix } = settings;
const { stablePrefix: c4dPrefix } = settings;

/**
* Legal nav.
Expand All @@ -37,24 +37,22 @@ class C4DLegalNav extends StableSelectorMixin(LitElement) {
*/
@property()
size = FOOTER_SIZE.REGULAR;

/**
* Navigation label for accessibility.
*/
@property()
navLabel = 'Legal Navigation';
/**
* The adjunct links container
*/

@query(`.${c4dPrefix}--adjunct-links__container`)
private _adjunctLinksContainer?: HTMLDivElement;

/**
* The adjunct links slot
*/
@query('[name="adjunct-links"]')
private _adjunctLinksSlot?: HTMLSlotElement;

@state()
protected _hasAdjunctLinks = false;

/**
* Returns a class-name based on the type parameter type
*/
Expand All @@ -65,16 +63,16 @@ class C4DLegalNav extends StableSelectorMixin(LitElement) {
});
}

protected _handleAdjunctLinksVisibility() {
const {
_adjunctLinksContainer: adjunctLinksContainer,
_adjunctLinksSlot: adjunctLinksSlot,
} = this;
/**
* Handles slot change event of adjunct-links slot to track if there are any.
*/
protected _handleAdjunctLinksVisibility = () => {
const { _adjunctLinksSlot: adjunctLinksSlot } = this;

this._hasAdjunctLinks =
(adjunctLinksSlot?.assignedNodes().length || 0) !== 0;
};

const hiddenClass = `${prefix}--adjunct-links__container--hidden`;
const isEmpty = (adjunctLinksSlot?.assignedNodes().length || 0) === 0;
adjunctLinksContainer?.classList.toggle(hiddenClass, isEmpty);
}
/**
* The shadow slot this legal nav should be in.
*/
Expand All @@ -88,8 +86,14 @@ class C4DLegalNav extends StableSelectorMixin(LitElement) {
super.connectedCallback();
}

firstUpdated() {
const { _adjunctLinksSlot: adjunctLinksSlot } = this;
this._hasAdjunctLinks =
(adjunctLinksSlot?.assignedNodes().length || 0) !== 0;
}

render() {
const { navLabel } = this;
const { navLabel, _hasAdjunctLinks: hasAdjunctLinks } = this;
return this.size !== FOOTER_SIZE.MICRO
? html`
<nav
Expand All @@ -106,8 +110,10 @@ class C4DLegalNav extends StableSelectorMixin(LitElement) {
</div>
<div
part="adjunct-links-container"
class="${c4dPrefix}--adjunct-links__container">
<ul part="adjunct-links-list">
class="${c4dPrefix}--adjunct-links__container${hasAdjunctLinks
? ''
: ` ${c4dPrefix}--adjunct-links__container--hidden`}">
<ul part="adjunct-links-list adjunct-links-list">
<slot
name="adjunct-links"
@slotchange="${this._handleAdjunctLinksVisibility}"></slot>
Expand Down
Loading