fix(toc): alignment issues #12118
Merged
fix(toc): alignment issues #12118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andy-blum
requested review from
m4olivei,
bruno-amorim,
marcelojcs and
Valentin-Sorin-Nicolae
and removed request for
a team
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
m4olivei
reviewed
Nov 22, 2024
m4olivei
approved these changes
Nov 22, 2024
| @@ -102,14 +102,17 @@ $hover-transition-timing: 95ms; | |||
|
|
|||
| position: inherit; | |||
| z-index: 10; | |||
| padding: 0; | |||
|
|
|||
| box-sizing: border-box; | |||
There was a problem hiding this comment.
This fixes the issue. Quick check of some v1 components, seems like in v1 there was a * { box-sizing: border-box; } rule added for all components, as part of some reset? I guess that's a change in v2. Something to keep in mind. I'm not suggesting we change at global level like that though, too far reaching for where we're at.
There was a problem hiding this comment.
yeah I saw that - wondering if that's a change from all the way up in carbon/carbon?
andy-blum
added
the
Ready to merge
|
Hey there! This issue/pull request was referenced in recently released v2.16.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
https://jsw.ibm.com/browse/ADCMS-6886
Description
Fixes alignment changes between v1 & v2 as exhibited here
Changelog
Changed
stylelint --fixtoyarn formatcommand