feat(video-player): migrate caem-video-player features #12113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4olivei
requested review from
bruno-amorim,
marcelojcs,
andy-blum and
Valentin-Sorin-Nicolae
and removed request for
a team
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andy-blum
added
adopter: Innovation Team
bruno-amorim
approved these changes
Dec 5, 2024
There was a problem hiding this comment.
LGTM! Great work @m4olivei
I once used a bit of MutationObserver, nice to see IntersectionObserver in action through your code!
andy-blum
approved these changes
Dec 23, 2024
andy-blum
added
the
Ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
ADCMS-6664
Description
Migrates features from
caem-video-playerandcaem-video-player-containermainlyintersection-mode, which works for scrolling video into view, as well as multiple card in card with video in a carousel.Testing instructions
<c4d-carousel>componentChangelog
New
intersection-modeattribute for<c4d-video-player>which will auto play/pause as the video scrolls into / out of the viewport