Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): update package import paths with .js ext #12110

Merged

Conversation

m4olivei
Copy link
Contributor

Related Ticket(s)

Closes #12109

Description

Adjusts import paths for recent additions that missed the .js file extension.

Changelog

Changed

  • Adjusts import paths for packages with strict package exports to add .js extension.

@m4olivei m4olivei requested a review from a team as a code owner November 18, 2024 19:49
@m4olivei m4olivei requested review from bruno-amorim, marcelojcs, andy-blum and Valentin-Sorin-Nicolae and removed request for a team November 18, 2024 19:49
Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit 22986ca
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/673cccd84feaac0008af35d4
😎 Deploy Preview https://deploy-preview-12110--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 18, 2024

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit 22986ca
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/673cccd872a3050008c0b759
😎 Deploy Preview https://deploy-preview-12110--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m4olivei m4olivei added bug Something isn't working dev Needs some dev work bug: not a bug Used when a bug is initially created, after investigating no code fix is needed. adopter: AEM used when component or pattern will be used by this adopter owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants and removed bug: not a bug Used when a bug is initially created, after investigating no code fix is needed. labels Nov 18, 2024
Copy link
Contributor

@Valentin-Sorin-Nicolae Valentin-Sorin-Nicolae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be an easy one and all looks good.

@m4olivei m4olivei added the Ready to merge Label for the pull requests that are ready to merge label Nov 19, 2024
@m4olivei m4olivei removed the Ready to merge Label for the pull requests that are ready to merge label Nov 19, 2024
@m4olivei m4olivei added the Ready to merge Label for the pull requests that are ready to merge label Nov 19, 2024
@kodiakhq kodiakhq bot merged commit 1c28902 into carbon-design-system:main Nov 19, 2024
20 of 24 checks passed
@m4olivei m4olivei deleted the fix/bundler-import-path-fix branch November 19, 2024 18:04
Copy link
Contributor

Hey there! This issue/pull request was referenced in recently released v2.16.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adopter: AEM used when component or pattern will be used by this adopter bug Something isn't working dev Needs some dev work owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
3 participants