feat(masthead): update simple megamenu #12108
Conversation
andy-blum
added
the
test: CDN preview
andy-blum
requested review from
m4olivei,
bruno-amorim,
marcelojcs and
Valentin-Sorin-Nicolae
and removed request for
a team
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Deploy preview created for package Built with commit: de869b404c8e82e583b1b3c2eb115787443d930a |
| ` | ||
| : null} | ||
| <c4d-megamenu-left-navigation> | ||
| <span>${title}</span> |
There was a problem hiding this comment.
Is this supposed to be a link? Also, have we considered if this should be a heading?
There was a problem hiding this comment.
It should not be a link, I considered a heading, but wasn't sure if that was the right semantics. Considering also adding aria-hidden to make this a presentation-only element.
There was a problem hiding this comment.
Right, on closer look that seems fine. Especially considering the <c4d-megamenu-right-navigation> can have an <h2> (see below). I mean, if design is saying that the repetition is useful for sighted users, it should follow that its useful for non-sighted users, so I'd avoid using aria-hidden.
Also we should probably add a part attribute to the <span>.
Related Ticket(s)
https://jsw.ibm.com/browse/ADCMS-6733
Description
Updates the "simple" megamenu to add a title element to the left-side portion.
Changelog
Changed