refactor(tile): use relative paths for imports in the same pkg #12103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4olivei
requested review from
bruno-amorim,
marcelojcs,
andy-blum and
Valentin-Sorin-Nicolae
and removed request for
a team
✅ Deploy Preview for ibm-dotcom-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for ibm-dotcom-web-components-react-wrap ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
andy-blum
approved these changes
Nov 12, 2024
|
@andy-blum fyi, I approved the Percy changes reported on the tile component. Second time I've done that. They are reported as different everytime on account of the randomized lorem ipsum. Maybe we need a knob for a seed value somehow to get "consistent" randomness. |
m4olivei
added
the
Ready to merge
kodiakhq
bot
merged commit c1a18e1
into
carbon-design-system:main
20 of 24 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
ADCMS-6691
Follow up to #12091
Description
Quick followup to #12091. Updates imports for the same package to be relative paths. Can avoid weird local development / bundling bugs and maintains consistency with the rest of the codebase.
Changelog
Changed
import '@carbon/ibmdotcom-web-components/es*';imports to relative path imports.