Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] fix e2e-storybook tests #12085

Merged

Conversation

m4olivei
Copy link
Contributor

@m4olivei m4olivei commented Oct 29, 2024

Description

The e2e-storybook tests have been failing for quite awhile. The tests do not appear to have been updated for v2. In many cases, the tests are using the old v1 prefixes.

The goal here is:

  • Fix test suite so that it will run on CI
  • Bulk update prefixes in the tests. In some places fix the tests where its simple to do so.
  • Skip tests that are broken for now. To follow up later. Lets get clean CI. Intent long term is to evaluate all skipped tests, update them to be of value, or remove them.
  • e2e-tests-parallel job should run green

Changelog

Changed

  • Update e2e-storybook integration tests with v2 prefixes
  • Update CI scripts / config so that e2e-tests-paralllel job runs green

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for ibm-dotcom-web-components ready!

Name Link
🔨 Latest commit d95c560
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components/deploys/673ceab58b5bf100083c7678
😎 Deploy Preview https://deploy-preview-12085--ibm-dotcom-web-components.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 29, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 29, 2024

Copy link

netlify bot commented Nov 13, 2024

Deploy Preview for ibm-dotcom-web-components-react-wrap ready!

Name Link
🔨 Latest commit d95c560
🔍 Latest deploy log https://app.netlify.com/sites/ibm-dotcom-web-components-react-wrap/deploys/673ceab5309b660008e01940
😎 Deploy Preview https://deploy-preview-12085--ibm-dotcom-web-components-react-wrap.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m4olivei m4olivei marked this pull request as ready for review November 19, 2024 17:17
@m4olivei m4olivei requested a review from a team as a code owner November 19, 2024 17:17
@m4olivei m4olivei requested review from bruno-amorim, marcelojcs, andy-blum and Valentin-Sorin-Nicolae and removed request for a team November 19, 2024 17:17
Copy link
Contributor

@andy-blum andy-blum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of tests we've updated to skip - Many seem to be "did it render right?" kinds of tests, which we should probably just delete to let Percy handle them, but the TOC, for example, has some functional tests skipped.

Other than that it's basically all license, formatting and prefix updates.

@andy-blum andy-blum added the Ready to merge Label for the pull requests that are ready to merge label Nov 20, 2024
@kodiakhq kodiakhq bot merged commit b2f7087 into carbon-design-system:main Nov 20, 2024
25 checks passed
@m4olivei m4olivei deleted the test/e2e-tests-parallel-fix branch November 20, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants