Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(file uploader): Drag and drop not working #11536

Merged
merged 3 commits into from
Feb 19, 2024
Merged

fix(file uploader): Drag and drop not working #11536

merged 3 commits into from
Feb 19, 2024

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #11508

Description

Drag and drop functionality doesn't work in File uploader component.

Changelog

Changed

  • Get files logic updated to include drag and drop files.

@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner February 14, 2024 05:33
@sangeethababu9223 sangeethababu9223 requested review from IgnacioBecerra and annawen1 and removed request for a team February 14, 2024 05:33
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 14, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11536/index.html

Built with commit: 58a7c30e164c85176401e1d59079dd8d9f1c18a5

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 14, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11536/index.html

Built with commit: 58a7c30e164c85176401e1d59079dd8d9f1c18a5

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 14, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11536/index.html

Built with commit: 58a7c30e164c85176401e1d59079dd8d9f1c18a5

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 14, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11536/index.html

Built with commit: 58a7c30e164c85176401e1d59079dd8d9f1c18a5

emyarod
emyarod approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@ariellalgilmore ariellalgilmore merged commit 0e75f3b into carbon-design-system:main Feb 19, 2024
12 of 19 checks passed
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 12, 2024
@sangeethababu9223 @ariellalgilmore @kennylam
fix(file uploader): drag and drop not working (carbon-design-system#1…
0023af7 
…1536)

Co-authored-by: Ariella Gilmore <[email protected]>
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@sangeethababu9223 @ariellalgilmore
fix(file uploader): drag and drop not working (carbon-design-system#1…
8d7a40e 
…1536)

Co-authored-by: Ariella Gilmore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File Uploader Drag & Drop Doesn't Work
4 participants
@sangeethababu9223 @ibmdotcom-bot @emyarod @ariellalgilmore