Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(background-media): expose gradient-hidden option #11518

Merged
merged 1 commit into from
Feb 10, 2024
Merged

feat(background-media): expose gradient-hidden option #11518

merged 1 commit into from
Feb 10, 2024

Conversation

jkaeser
Copy link
Member

@jkaeser jkaeser commented Feb 9, 2024 •
edited by m4olivei
Loading

Related Ticket(s)

Jira Ticket

Description

We already had functionality built-in to the Background Media component that can optionally hide the gradient effect that overlays the media. This PR exposes that option to end users and documents the feature in Storybook.

Changelog

Changed

  • Exposes DDSBackgroundMedia's gradient-hidden option that, when true, disables the gradient overlay.

To Test

Visit the Background Media stories in the deploy preview and verify the "hide gradient" checkbox functions as expected.

@jkaeser jkaeser added package: web components Work necessary for the IBM.com Library web components package adopter: AEM used when component or pattern will be used by this adopter owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants v1 labels Feb 9, 2024
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11518/index.html

Built with commit: 74640ad01758d2b0c458b2eaa01c37685abc66a4

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11518/index.html

Built with commit: 74640ad01758d2b0c458b2eaa01c37685abc66a4

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11518/index.html

Built with commit: 74640ad01758d2b0c458b2eaa01c37685abc66a4

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/11518/index.html

Built with commit: 74640ad01758d2b0c458b2eaa01c37685abc66a4

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11518/index.html

Built with commit: 74640ad01758d2b0c458b2eaa01c37685abc66a4

@jkaeser jkaeser marked this pull request as ready for review February 9, 2024 19:16
@jkaeser jkaeser requested a review from a team as a code owner February 9, 2024 19:16
andy-blum
andy-blum approved these changes Feb 9, 2024
View reviewed changes
Copy link
Contributor

@andy-blum andy-blum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! love it when past-us does the work for now-us

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Feb 10, 2024
@kodiakhq kodiakhq bot merged commit fdfa26e into carbon-design-system:v1 Feb 10, 2024
28 of 30 checks passed
@jkaeser jkaeser deleted the feat/background-media-no-gradient branch February 12, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andy-blum andy-blum andy-blum approved these changes

@kennylam kennylam kennylam approved these changes

@m4olivei m4olivei m4olivei approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
adopter: AEM used when component or pattern will be used by this adopter owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jkaeser @ibmdotcom-bot @m4olivei @kennylam @andy-blum