Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(masthead-v2-alpha): merge latest from alpha dev into alpha release #11513

Closed
wants to merge 1 commit into from
Closed

chore(masthead-v2-alpha): merge latest from alpha dev into alpha release #11513

wants to merge 1 commit into from

Conversation

jkaeser
Copy link
Member

@jkaeser jkaeser commented Feb 9, 2024

This gets the HTML template minifications cherry-picked in #11504 into the release branch.

@jkaeser
chore(masthead-v2-alpha): cherry pick template literal minification (#…
01d10f5 
…11504)

* chore(rollup): minify html template literals (v1) (#11471)

Closes # [ADCMS-4317](https://jsw.ibm.com/browse/ADCMS-4317)

Adding a rollup plugin to the C4IBM build step to minify HTML template literals to reduce the DOM node count in web component shadow DOM subtrees.

**New**

- Adds `rollup-plugin-minify-html-literals` dependency to `carbon-web-components` and `web-components` packages, and uses the plugin in Rollup build config.

**Changed**

- Replaces directional property in Table of Contents component with corresponding logical property.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->

* chore(yarn): update lock file
@jkaeser jkaeser added package: web components Work necessary for the IBM.com Library web components package adopter: AEM used when component or pattern will be used by this adopter owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants Masthead L0/L1 v2 used when component or pattern is part of the Mashead V2 update effort labels Feb 9, 2024
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11513/index.html

Built with commit: 01d10f51ca87ba8b57b679da96cb796bf35e3dcf

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11513/index.html

Built with commit: 01d10f51ca87ba8b57b679da96cb796bf35e3dcf

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11513/index.html

Built with commit: 01d10f51ca87ba8b57b679da96cb796bf35e3dcf

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11513/index.html

Built with commit: 01d10f51ca87ba8b57b679da96cb796bf35e3dcf

@jkaeser jkaeser closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
adopter: AEM used when component or pattern will be used by this adopter Masthead L0/L1 v2 used when component or pattern is part of the Mashead V2 update effort owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkaeser @ibmdotcom-bot