Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(code-snippet): multi copy button #11492

Merged
merged 2 commits into from
Feb 7, 2024
Merged

fix(code-snippet): multi copy button #11492

merged 2 commits into from
Feb 7, 2024

Conversation

ariellalgilmore
Copy link
Member

@ariellalgilmore ariellalgilmore commented Feb 5, 2024 •
edited
Loading

Related Ticket(s)

Closes #11475

Description

copy button is getting hidden in code-snippet multi.

Changelog

Changed

  • added z-index: 10 to follow react styles

@ariellalgilmore ariellalgilmore marked this pull request as ready for review February 5, 2024 17:52
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner February 5, 2024 17:52
@ariellalgilmore ariellalgilmore requested review from emyarod and sangeethababu9223 and removed request for a team February 5, 2024 17:52
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 5, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11492/index.html

Built with commit: 7a86a71310fd395e4ebb1a65b73bbe0ba0694a9a

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 5, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11492/index.html

Built with commit: 7a86a71310fd395e4ebb1a65b73bbe0ba0694a9a

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 5, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11492/index.html

Built with commit: 7a86a71310fd395e4ebb1a65b73bbe0ba0694a9a

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 5, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11492/index.html

Built with commit: 7a86a71310fd395e4ebb1a65b73bbe0ba0694a9a

kennylam
kennylam approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Feb 7, 2024
@kodiakhq kodiakhq bot merged commit c65ed61 into carbon-design-system:main Feb 7, 2024
12 of 19 checks passed
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 12, 2024
@ariellalgilmore @kennylam
fix(code-snippet): multi copy button (carbon-design-system#11492)
c15c09b 
### Related Ticket(s)

Closes carbon-design-system#11475

### Description

copy button is getting hidden in code-snippet multi. 
### Changelog

**Changed**

- added z-index: 10 to follow react styles

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@ariellalgilmore
fix(code-snippet): multi copy button (carbon-design-system#11492)
1e536c8 
### Related Ticket(s)

Closes carbon-design-system#11475

### Description

copy button is getting hidden in code-snippet multi. 
### Changelog

**Changed**

- added z-index: 10 to follow react styles

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CWC cds-code-snippet]: copy button is hidden
3 participants
@ariellalgilmore @ibmdotcom-bot @kennylam