Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storybook): finalize storybook 7 upgrade #11480

Conversation

IgnacioBecerra
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra commented Feb 2, 2024

Related Ticket(s)

Closes #11496

Description

This PR does the following:

  • resolve circular dependencies in .mdx and *.stories.ts files sometimes prevent stories to load at first
  • remove the <Meta> from some .mdx files as it prevents loading when different stories share the same documentation file
  • removing unattached .mdx files from showing up on the sidebar as standalone docs
  • Replace Description with Markdown in all the doc files, as well as updating some other deprecated SB functions
  • Update the only missing story: Stack

Changelog

New

  • Stack story is updated to SB7

Changed

  • replaced Description with Markdown for all stories
  • general cleanup

Removed

  • doc parameter removed from Story meta as it is not needed, included storyDoc import in story files
  • removed unattached, duplicated standalone story docs

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 2, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 2, 2024

@IgnacioBecerra IgnacioBecerra marked this pull request as ready for review February 7, 2024 01:11
@IgnacioBecerra IgnacioBecerra requested a review from a team as a code owner February 7, 2024 01:11
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! one small thing, I know not all of the ci-checks are gonna pass, but there are things like formatting and possibly others that might pop up that we could resolve now
Screenshot 2024-02-07 at 7 45 08 AM

Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@kennylam kennylam merged commit 7bc80e0 into carbon-design-system:feat/cwc-storybook-7-vite Feb 7, 2024
6 of 11 checks passed
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
…1480)

* feat(stack): update to v7

* chore(main): adjust configs and added story-source

* docs(vite): replace webpack mentions to vite

* docs(storybook): using non-deprecated import path

* fix(skeleton-icon): moved to stackblitz folder

* fix(docs): using markdown & remove doc parameter

* fix(storybook): hide unattached mdx

* fix(docs): remove variable

* chore(prettier): format code

---------

Co-authored-by: Kenny Lam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants