Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(video player): thumbnail and play button issue #11450

Merged
merged 7 commits into from
Jan 31, 2024
Merged

fix(video player): thumbnail and play button issue #11450

merged 7 commits into from
Jan 31, 2024

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #11399

Description

Video component has no play button and thumbnail is not correctly displayed.

Changelog

Changed

  • padding-block-start css property for the c4d-image component is changed to 0.

@sangeethababu9223 sangeethababu9223 added dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package labels Jan 25, 2024
@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner January 25, 2024 09:54
@sangeethababu9223 sangeethababu9223 requested review from emyarod and IgnacioBecerra and removed request for a team January 25, 2024 09:54
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11450/index.html

Built with commit: 072aa09276c3e478af9895a375a07f1af0c39223

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11450/index.html

Built with commit: 072aa09276c3e478af9895a375a07f1af0c39223

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11450/index.html

Built with commit: 072aa09276c3e478af9895a375a07f1af0c39223

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 25, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11450/index.html

Built with commit: 072aa09276c3e478af9895a375a07f1af0c39223

ariellalgilmore
ariellalgilmore approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

IgnacioBecerra
IgnacioBecerra approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT! thanks @sangeethababu9223

@IgnacioBecerra IgnacioBecerra added the Ready to merge Label for the pull requests that are ready to merge label Jan 29, 2024
@kodiakhq kodiakhq bot merged commit 1bfb57a into carbon-design-system:main Jan 31, 2024
16 of 19 checks passed
m4olivei pushed a commit to m4olivei/carbon-for-ibm-dotcom that referenced this pull request Feb 1, 2024
@sangeethababu9223 @m4olivei
fix(video player): thumbnail and play button issue (carbon-design-sys…
f004e82 
…tem#11450)

### Related Ticket(s)

Closes carbon-design-system#11399

### Description

Video component has no play button and thumbnail is not correctly displayed.

### Changelog

**Changed**

- `padding-block-start` css property for the `c4d-image` component is changed to 0.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
dev Needs some dev work package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web-components]: Video component has no play button and thumbnail is not correctly displayed
5 participants
@sangeethababu9223 @ibmdotcom-bot @ariellalgilmore @IgnacioBecerra @kennylam