Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input): display default value properly #11411

Merged
merged 2 commits into from
Jan 18, 2024
Merged

fix(input): display default value properly #11411

merged 2 commits into from
Jan 18, 2024

Conversation

IgnacioBecerra
Copy link
Contributor

Related Ticket(s)

Closes #11391

Description

Ensures bx-input value property works as intended

Changelog

Changed

  • now uses this.value instead of this._value as the latter isn't used anywhere

Removed

  • _value internal property

@IgnacioBecerra IgnacioBecerra requested a review from a team as a code owner January 17, 2024 15:55
ariellalgilmore
ariellalgilmore reviewed Jan 17, 2024
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like number-input also needs to be updated
Screenshot 2024-01-17 at 8 58 58 AM

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11411/index.html

Built with commit: e55e986146cbc8b9c30997536e81bf851da60cb5

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11411/index.html

Built with commit: e55e986146cbc8b9c30997536e81bf851da60cb5

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11411/index.html

Built with commit: e55e986146cbc8b9c30997536e81bf851da60cb5

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11411/index.html

Built with commit: e55e986146cbc8b9c30997536e81bf851da60cb5

@kennylam kennylam closed this Jan 18, 2024
@kennylam kennylam reopened this Jan 18, 2024
@kennylam kennylam closed this Jan 18, 2024
@kennylam kennylam reopened this Jan 18, 2024
@kennylam kennylam closed this Jan 18, 2024
@kennylam kennylam reopened this Jan 18, 2024
@kennylam kennylam closed this Jan 18, 2024
@kennylam kennylam reopened this Jan 18, 2024
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/11411/index.html

Built with commit: e55e986146cbc8b9c30997536e81bf851da60cb5

kennylam
kennylam approved these changes Jan 18, 2024
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam added Ready to merge Label for the pull requests that are ready to merge package: carbon web components labels Jan 18, 2024
@kodiakhq kodiakhq bot merged commit 32cffc8 into carbon-design-system:release/v1.55.0 Jan 18, 2024
17 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore left review comments

@kennylam kennylam kennylam approved these changes

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IgnacioBecerra @ibmdotcom-bot @kennylam @ariellalgilmore