Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dropdown): remove excess border of first dropdown element #11400

Merged
merged 8 commits into from
Feb 2, 2024
Merged

fix(dropdown): remove excess border of first dropdown element #11400

merged 8 commits into from
Feb 2, 2024

Conversation

ko1ebayev
Copy link
Contributor

Related Ticket(s)

#11271

Closes #11271

Description

Just querying first element of dropdown and removing its border-block-start-width

Changelog

Changed

  • updated dropdown.scss with 5 new lines

@ko1ebayev ko1ebayev requested a review from a team as a code owner January 12, 2024 14:06
@ko1ebayev ko1ebayev requested review from IgnacioBecerra and annawen1 and removed request for a team January 12, 2024 14:06
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024 •
edited
Loading

DCO Assistant Lite bot All Contributors have signed the CLA.

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 12, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11400/index.html

Built with commit: 11ed5c8c13a4f3b6c1c893cccf6b5b7b38d942fd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 12, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11400/index.html

Built with commit: 11ed5c8c13a4f3b6c1c893cccf6b5b7b38d942fd

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 12, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11400/index.html

Built with commit: 11ed5c8c13a4f3b6c1c893cccf6b5b7b38d942fd

@ko1ebayev
Copy link
Contributor Author

I have read the DCO document and I hereby sign the DCO.

@ko1ebayev
Copy link
Contributor Author

recheck

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 21, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11400/index.html

Built with commit: 11ed5c8c13a4f3b6c1c893cccf6b5b7b38d942fd

IgnacioBecerra
IgnacioBecerra approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@IgnacioBecerra IgnacioBecerra added Ready to merge Label for the pull requests that are ready to merge package: carbon web components dev Needs some dev work labels Feb 1, 2024
@kodiakhq kodiakhq bot merged commit a0830b0 into carbon-design-system:main Feb 2, 2024
12 of 19 checks passed
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 12, 2024
@ko1ebayev @kennylam
fix(dropdown): remove excess border of first dropdown element (carbon…
fffee6e 
…-design-system#11400)

### Related Ticket(s)

carbon-design-system#11271 

Closes carbon-design-system#11271 

### Description

Just querying first element of dropdown and removing its `border-block-start-width`

### Changelog

**Changed**

- updated `dropdown.scss` with 5 new lines
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@ko1ebayev
fix(dropdown): remove excess border of first dropdown element (carbon…
35a64da 
…-design-system#11400)

### Related Ticket(s)

carbon-design-system#11271 

Closes carbon-design-system#11271 

### Description

Just querying first element of dropdown and removing its `border-block-start-width`

### Changelog

**Changed**

- updated `dropdown.scss` with 5 new lines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
dev Needs some dev work package: carbon web components Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[carbon-web-components]: Additional border in the first item in Dropdown
4 participants
@ko1ebayev @ibmdotcom-bot @IgnacioBecerra @kennylam