Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wc): build errors #11398

Conversation

ariellalgilmore
Copy link
Member

Related Ticket(s)

Closes #none

Description

Cleaned up build errors in web-components in the feat/cwc-storybook-7-vite branch, but still unable to get storybook to run

Changelog

New

  • {{new thing}}

Changed

  • {{changed thing}}

Removed

  • {{removed thing}}

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 12, 2024

@ariellalgilmore ariellalgilmore marked this pull request as ready for review January 16, 2024 15:24
@ariellalgilmore ariellalgilmore requested a review from a team as a code owner January 16, 2024 15:24
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took a little bit to get this merged, but we definitely need this in preparation to merge it into main. Thanks @ariellalgilmore, LGTM!

@ibmdotcom-bot
Copy link
Contributor

@IgnacioBecerra IgnacioBecerra merged commit c37386f into carbon-design-system:feat/cwc-storybook-7-vite Feb 7, 2024
8 of 13 checks passed
@ariellalgilmore ariellalgilmore deleted the fix/web-component-build-errors branch February 7, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants