Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(multi-select): update story to Storybook v7 #11327

Conversation

m4olivei
Copy link
Contributor

@m4olivei m4olivei commented Jan 4, 2024

Related Ticket(s)

Closes #11326

Description

Adjustments to multi-select component to be compatible with Storybook v7.

Changelog

Changed

  • Updated multi-select Storybook component for Storybook v7.

@m4olivei m4olivei requested a review from a team as a code owner January 4, 2024 17:41
@m4olivei m4olivei requested review from kennylam and sangeethababu9223 and removed request for a team January 4, 2024 17:41
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 8, 2024

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m4olivei Nice one! Looks like disabled, invalid, and readOnly don't have controls though.

@m4olivei
Copy link
Contributor Author

@m4olivei Nice one! Looks like disabled, invalid, and readOnly don't have controls though.

Nice catch! This is fixed in the most recent commit.

Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam merged commit 9705c48 into carbon-design-system:feat/cwc-storybook-7-vite Jan 10, 2024
7 of 14 checks passed
kennylam added a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
…m#11327)

* chore(multi-select): rename story files for sb v7

* chore(multi-select): update file-uploader to sb v7

* chore(multi-select): include sb layer components, remove unused import

* fix(multi-select): controls for disabled, readOnly and invalid

---------

Co-authored-by: kennylam <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants