feat(content-switcher): update story to Storybook v7 #11315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4olivei
requested review from
emyarod and
IgnacioBecerra
and removed request for
a team
|
Deploy preview created for package Built with commit: 90805eceea3adbf791e9dc3d7001f63aa217eaff |
RichKummer
reviewed
Jan 8, 2024
There was a problem hiding this comment.
Hey @m4olivei
Looks good, but just found one issue. When looking at the with Layer version with a smaller width screen, the content switchers break out of the layering set up. In React, the content switchers more naturally condense in size.
React version:
This build:
m4olivei
force-pushed
the
chore/content-switcher-sb-v7
branch
from
9491e17 to
c5146b7
Compare
kennylam
merged commit 2e29308
into
carbon-design-system:feat/cwc-storybook-7-vite
5 of 12 checks passed
kennylam
added a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this pull request
Jun 11, 2024
…ystem#11315) * chore(content-switcher): update content-switcher to sb v7 * fix(content-switcher): add imports for content-switcher dependencies * fix(content-switcher): fix css selector for icon only styles * fix(content-switcher): restore the size options * chore(content-switcher): include storybook layers components --------- Co-authored-by: kennylam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Closes #11313
Description
Adjustments to content-switcher component to be compatible with Storybook v7.
Changelog
Changed