Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cypress): adding more tests to the pricing table cells #11286

Merged
merged 6 commits into from
Mar 4, 2024
Merged

feat(cypress): adding more tests to the pricing table cells #11286

merged 6 commits into from
Mar 4, 2024

Conversation

bruno-amorim
Copy link
Contributor

Related Ticket(s)

Closes # ADCMS-4051

Description

We created a regression when implementing the Pricing Table Cell feature to align text next to the optional icons. Then we almost wiped out the side-by-side alignment feature when fixing the regression. This all occurred because our current tests don't adequately reflect our expected functionality.

We need tests for the following cases:

  1. When the icon feature is enabled, user-entered cell content should appear next to the icon.

  2. User-entered content should appear in a vertical column layout whether there's an icon enabled or not.

@bruno-amorim bruno-amorim requested a review from a team as a code owner January 2, 2024 18:20
@bruno-amorim bruno-amorim requested review from IgnacioBecerra and sangeethababu9223 and removed request for a team January 2, 2024 18:20
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 2, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11286/index.html

Built with commit: 50fdbf284554f5ad72789bbce2a34292b695603a

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 2, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11286/index.html

Built with commit: 50fdbf284554f5ad72789bbce2a34292b695603a

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 2, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11286/index.html

Built with commit: 50fdbf284554f5ad72789bbce2a34292b695603a

andy-blum
andy-blum previously requested changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@andy-blum andy-blum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading through the test you added and the logic seems sound, but we're missing the second test condition:

User-entered content should appear in a vertical column layout whether there's an icon enabled or not.

See @oliviaflory's comment here for a screenshot of what problem we're looking to avoid.

@bruno-amorim bruno-amorim requested a review from andy-blum January 4, 2024 17:56
jkaeser
jkaeser suggested changes Jan 18, 2024
View reviewed changes
Copy link
Member

@jkaeser jkaeser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this one, @bruno-amorim! It's looking great so far. I think the second test case still needs some work, though. See my comment and let me know if you have any questions.

packages/web-components/tests/e2e-storybook/cypress/integration/pricing-table/_tests.js Outdated Show resolved Hide resolved
@bruno-amorim bruno-amorim requested a review from jkaeser January 29, 2024 19:49
@bruno-amorim
Copy link
Contributor Author

Hey @jkaeser
I've rewritten the logic to test the vertically aligned texts. Would you please check it now?

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 29, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11286/index.html

Built with commit: 50fdbf284554f5ad72789bbce2a34292b695603a

@jkaeser
Copy link
Member

jkaeser commented Jan 30, 2024

@bruno-amorim Don't forget to re-target this against the v1 branch.

@bruno-amorim bruno-amorim changed the base branch from main to v1 January 31, 2024 17:55
@m4olivei m4olivei force-pushed the feat/pricing-table-cell-tests branch from 21e535d to b3c2188 Compare January 31, 2024 21:43
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 31, 2024 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/11286/index.html

Built with commit: 50fdbf284554f5ad72789bbce2a34292b695603a

m4olivei
m4olivei approved these changes Feb 1, 2024
View reviewed changes
Copy link
Contributor

@m4olivei m4olivei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. Tests passing. I just merged v1 changes, otherwise this should be good to go.

@jkaeser jkaeser dismissed andy-blum’s stale review February 1, 2024 17:24

Andy's review is out of date.

@jkaeser jkaeser added the package: web components Work necessary for the IBM.com Library web components package label Feb 1, 2024
@jkaeser jkaeser added owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants 👀 eyes needed v1 labels Feb 1, 2024
@annawen1 annawen1 added Ready to merge Label for the pull requests that are ready to merge and removed 👀 eyes needed labels Mar 4, 2024
@kodiakhq kodiakhq bot merged commit 55fcfa1 into carbon-design-system:v1 Mar 4, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 approved these changes

@jkaeser jkaeser jkaeser approved these changes

@m4olivei m4olivei m4olivei approved these changes

@marcelojcs marcelojcs Awaiting requested review from marcelojcs

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@sangeethababu9223 sangeethababu9223 Awaiting requested review from sangeethababu9223 sangeethababu9223 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@andy-blum andy-blum Awaiting requested review from andy-blum

Assignees
No one assigned
Labels
owner: Innovation Team used when the engineering work will be done by Hybrid Cloud with DDS engineers as consultants package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bruno-amorim @ibmdotcom-bot @jkaeser @m4olivei @andy-blum @annawen1