Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tooltip): tooltip persists issue #11282

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #10471

Description

Carbon Web Components tooltip persists with certain delay durations. If the enter-delay-ms is higher than the leave-delay-ms tooltip doesn't work as expected.

Changelog

Changed

  • Added a condition to check if enter-delay-ms is higher than leave-delay-ms. And if so, the value of leave-delay-ms will be increased by the value of enter-delay-ms.

@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner January 1, 2024 06:38
@sangeethababu9223 sangeethababu9223 requested review from kennylam and emyarod and removed request for a team January 1, 2024 06:38
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 1, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 1, 2024

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 1, 2024

@IgnacioBecerra
Copy link
Contributor

@sangeethababu9223 Hm, I think making the leave delay match the enter delay might not be what we're looking for, since the component should work with different delay times as seen in the react story as well.

sangeethababu9223 and others added 4 commits January 4, 2024 09:42
…arbon-design-system#11244)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [@carbon/pictograms-react](https://togithub.com/carbon-design-system/carbon) ([source](https://togithub.com/carbon-design-system/carbon/tree/HEAD/packages/pictograms-react)) | [`11.54.0` -> `11.55.0`](https://renovatebot.com/diffs/npm/@carbon%2fpictograms-react/11.54.0/11.55.0) | [![age](https://developer.mend.io/api/mc/badges/age/npm/@carbon%2fpictograms-react/11.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@carbon%2fpictograms-react/11.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@carbon%2fpictograms-react/11.54.0/11.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@carbon%2fpictograms-react/11.54.0/11.55.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>carbon-design-system/carbon (@&carbon-design-system#8203;carbon/pictograms-react)</summary>

### [`v11.55.0`](https://togithub.com/carbon-design-system/carbon/compare/d9121f17b1dd935a5734c6eae10af275f72f6dc7...5dfe589ff6ce498c8f8040a55f05a15624e84df5)

[Compare Source](https://togithub.com/carbon-design-system/carbon/compare/d9121f17b1dd935a5734c6eae10af275f72f6dc7...5dfe589ff6ce498c8f8040a55f05a15624e84df5)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/carbon-design-system/carbon-for-ibm-dotcom).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy45My4xIiwidXBkYXRlZEluVmVyIjoiMzcuOTMuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
### Related Ticket(s)

Closes # {{Provide issue number link(s) to the related ticket(s) that this pull request addresses}}

### Description

{{Add a human-readable description / detail summary of what the PR is changing and any details around how and why}}

{{If applicable, include a screenshot indicating an example or examples of what the PR is changing in the application}}

### Changelog

**New**

- {{new thing}}

**Changed**

- {{changed thing}}

**Removed**

- {{removed thing}}

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@sangeethababu9223
Copy link
Member Author

@sangeethababu9223 Hm, I think making the leave delay match the enter delay might not be what we're looking for, since the component should work with different delay times as seen in the react story as well.

@IgnacioBecerra
Created a new PR with suggested changes from the reference given.
Closing the current PR since unwanted files had been accidentally pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Carbon Web Components tooltip persists with certain delay durations
4 participants