Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cta): feature image duplication issue #11264

Merged
merged 9 commits into from
Jan 10, 2024
Merged

fix(cta): feature image duplication issue #11264

merged 9 commits into from
Jan 10, 2024

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #10474

Description

CTA Feature enters a state in which images are duplicated when knob for CTA type changes from Video to other options.

Changelog

New

  • Added a condition to check if image component already exists or not before inserting the component to the DOM.
  • Added a condition to check the duplication of headline.

@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review December 21, 2023 06:28
@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner December 21, 2023 06:28
@sangeethababu9223 sangeethababu9223 requested review from emyarod and IgnacioBecerra and removed request for a team December 21, 2023 06:28
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 21, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11264/index.html

Built with commit: c651c148e3d1cfe1f88ebe08e064d98ee35bc167

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 21, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11264/index.html

Built with commit: c651c148e3d1cfe1f88ebe08e064d98ee35bc167

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 21, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11264/index.html

Built with commit: c651c148e3d1cfe1f88ebe08e064d98ee35bc167

emyarod
emyarod approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@emyarod emyarod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! just have an extra log statement in the story

packages/web-components/src/components/cta/__stories__/cta.stories.ts Outdated Show resolved Hide resolved
@ariellalgilmore
Copy link
Member

@sangeethababu9223 seems like you just need to run a yarn format and then this can be merged

@kennylam kennylam added package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge labels Jan 10, 2024
@kennylam kennylam merged commit 978521a into carbon-design-system:main Jan 10, 2024
10 of 20 checks passed
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Mar 12, 2024
@sangeethababu9223 @kennylam
fix(cta): feature image duplication issue (carbon-design-system#11264)
6d33d5d 
* fix(CTA): image duplication issue fix

* fix(cta): remove log statement

* fix(CTA): format cta.stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod emyarod approved these changes

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CTA Feature enters a state in which images are duplicated
5 participants
@sangeethababu9223 @ibmdotcom-bot @ariellalgilmore @emyarod @kennylam