Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tag): slug #11226

Merged
merged 6 commits into from
Dec 14, 2023
Merged

feat(tag): slug #11226

merged 6 commits into from
Dec 14, 2023

Conversation

annawen1
Copy link
Member

@annawen1 annawen1 commented Dec 13, 2023 •
edited
Loading

Related Ticket(s)

Closes #11143

Description

Adds slug to cds-tag component

Changelog

New

  • add new slot for icon
  • new story for tag with slug

Changed

  • set default in storybook for tag size to be medium
  • add styles specific to slug within tag to the slug stylesheet

Removed

  • hasCustomIcon property not needed - looking at Carbon React, the close icon doesn't get replaced

Testing

Experimental -> Slug -> Examples -> Tag

@annawen1 annawen1 changed the base branch from main to release-cwc/v2.1.0 December 13, 2023 16:32
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 13, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11226/index.html

Built with commit: 85085ce7b925ed2589842641de7ad51b21ba798e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 13, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11226/index.html

Built with commit: 85085ce7b925ed2589842641de7ad51b21ba798e

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 13, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11226/index.html

Built with commit: 85085ce7b925ed2589842641de7ad51b21ba798e

@annawen1 annawen1 marked this pull request as ready for review December 14, 2023 14:05
@annawen1 annawen1 requested a review from a team as a code owner December 14, 2023 14:05
@annawen1 annawen1 added package: carbon web components area: AI Used to filter issues in the Carbon for AI project. labels Dec 14, 2023
ariellalgilmore
ariellalgilmore approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

aagonzales
aagonzales approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@aagonzales aagonzales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is good! ✅

@annawen1 annawen1 merged commit 0c1f656 into carbon-design-system:release-cwc/v2.1.0 Dec 14, 2023
7 of 10 checks passed
@annawen1 annawen1 deleted the feat/tag-with-slug branch December 14, 2023 19:11
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@annawen1
feat(tag): slug (carbon-design-system#11226)
5a2ee6d 
* feat(tag): tag with slug

* feat(tag): icon slot for tag

* feat(slug): add tag specific styles for slug

* chore(ci-check): fix ts errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@aagonzales aagonzales aagonzales approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@IgnacioBecerra IgnacioBecerra Awaiting requested review from IgnacioBecerra IgnacioBecerra was automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
area: AI Used to filter issues in the Carbon for AI project. package: carbon web components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@annawen1 @ibmdotcom-bot @aagonzales @ariellalgilmore