Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ibmdotcom-styles) remove react classes from component styles #11218

Draft
wants to merge 44 commits into
base: main
Choose a base branch
from

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #11194

Description

Remove React classes from component styles

Changelog

Removed

  • Removed react classes from components in styles package

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 12, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 12, 2023

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 12, 2023

@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review December 18, 2023 08:27
@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner December 18, 2023 08:27
sangeethababu9223 and others added 5 commits December 18, 2023 13:57
…ign-system#11225)

Closes carbon-design-system#10960
[Jira ticket](https://jsw.ibm.com/browse/ADCMS-4074)

Alternate approach to fixing carbon-design-system#10960. Previously we had attempted a resolution that wrapped the whole card in `<a></a>`. That solution introduced regressions with accessibiltiy. It's also come to my attention that the approach is a well [known poor approach](https://css-tricks.com/block-links-are-a-pain-and-maybe-just-a-bad-idea/).

This solution takes the same approach as the Default Card component, which is to wrap the footer icon in a `<a></a>` and then absolute position a pseudo element child to make the whole card clickable still. More on [the pseudo-element  method](https://css-tricks.com/block-links-the-search-for-a-perfect-solution/#aa-method-3-the-good-ol-before-pseudo-element).

**Changed**

- Wrap the footer icon in a link for the card pictogram in the same way as the default card
- Adjustment to Storybook for Card so that the body copy is used on page load

**Removed**

- Remove the `role="button"` wrapper for pictogram card
…arbon-design-system#11249)

### Description

Re-adds workflow that allows Innovation Team to build masthead v2 alpha CDN bundles. Workflow originally authored by @jeffchew in carbon-design-system#11153.

### Changelog

**New**

- Restores masthead v2 alpha CDN bundle publishing workflow.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review January 8, 2024 07:28
@sangeethababu9223 sangeethababu9223 marked this pull request as draft January 11, 2024 07:59
@sangeethababu9223 sangeethababu9223 marked this pull request as ready for review January 17, 2024 15:17
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Jan 19, 2024

@m4olivei m4olivei marked this pull request as draft December 23, 2024 13:49
@m4olivei
Copy link
Contributor

This may still be worthwhile work, but it's getting crufty, and would need work to dust it off. Converting to Draft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@carbon/ibmdotcom-styles]: remove React classes from component styles
5 participants