-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ibmdotcom-styles) remove react classes from component styles #11218
base: main
Are you sure you want to change the base?
feat(ibmdotcom-styles) remove react classes from component styles #11218
Conversation
Deploy preview created for package Built with commit: fdda8054c353e40a03b18b021e0f8315e5f765c1 |
Deploy preview created for package Built with commit: fdda8054c353e40a03b18b021e0f8315e5f765c1 |
Deploy preview created for package Built with commit: fdda8054c353e40a03b18b021e0f8315e5f765c1 |
…es-remove-react-class-2
…ign-system#11225) Closes carbon-design-system#10960 [Jira ticket](https://jsw.ibm.com/browse/ADCMS-4074) Alternate approach to fixing carbon-design-system#10960. Previously we had attempted a resolution that wrapped the whole card in `<a></a>`. That solution introduced regressions with accessibiltiy. It's also come to my attention that the approach is a well [known poor approach](https://css-tricks.com/block-links-are-a-pain-and-maybe-just-a-bad-idea/). This solution takes the same approach as the Default Card component, which is to wrap the footer icon in a `<a></a>` and then absolute position a pseudo element child to make the whole card clickable still. More on [the pseudo-element method](https://css-tricks.com/block-links-the-search-for-a-perfect-solution/#aa-method-3-the-good-ol-before-pseudo-element). **Changed** - Wrap the footer icon in a link for the card pictogram in the same way as the default card - Adjustment to Storybook for Card so that the body copy is used on page load **Removed** - Remove the `role="button"` wrapper for pictogram card
…arbon-design-system#11249) ### Description Re-adds workflow that allows Innovation Team to build masthead v2 alpha CDN bundles. Workflow originally authored by @jeffchew in carbon-design-system#11153. ### Changelog **New** - Restores masthead v2 alpha CDN bundle publishing workflow. <!-- React and Web Component deploy previews are enabled by default. --> <!-- To enable additional available deploy previews, apply the following --> <!-- labels for the corresponding package: --> <!-- *** "test: e2e": Codesandbox examples and e2e integration tests --> <!-- *** "package: services": Services --> <!-- *** "package: utilities": Utilities --> <!-- *** "RTL": React / Web Components (RTL) --> <!-- *** "feature flag": React / Web Components (experimental) -->
Deploy preview created for package Built with commit: 208084b21684e494b6a86a985abca443b4abd902 |
This may still be worthwhile work, but it's getting crufty, and would need work to dust it off. Converting to Draft. |
Related Ticket(s)
Closes #11194
Description
Remove React classes from component styles
Changelog
Removed