feat(sidepanel): introduce side panel component #11201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Added |
jeffchew
changed the title
|
@annawen1 @ariellalgilmore I realise there are some conflicts to resolve, but would love some feedback on the WebComponent SidePanel implementation so far. Just want to make sure I'm not going in completely the wrong direction with my first WebComponent. |
lee-chase
force-pushed
the
feat/cwc-sidepanel
branch
from
e9c0f6a to
5279654
Compare
packages/carbon-web-components/src/components/side-panel/side-panel.ts
Outdated
Show resolved
Hide resolved
annawen1
reviewed
Dec 14, 2023
packages/carbon-web-components/src/components/side-panel/side-panel-header.ts
Outdated
Show resolved
Hide resolved
annawen1
reviewed
Dec 14, 2023
packages/carbon-web-components/src/components/side-panel/side-panel-header.ts
Outdated
Show resolved
Hide resolved
annawen1
reviewed
Dec 14, 2023
packages/carbon-web-components/src/components/side-panel/side-panel-story.ts
Outdated
Show resolved
Hide resolved
annawen1
reviewed
Dec 14, 2023
lee-chase
force-pushed
the
feat/cwc-sidepanel
branch
from
93676b2 to
2b50f2d
Compare
|
Deploy preview created for package Built with commit: eb47a754b0a4ee5d4d3a4b0104ab4cd44c92ace5 |
|
Deploy preview created for package Built with commit: eb47a754b0a4ee5d4d3a4b0104ab4cd44c92ace5 |
|
Deploy preview created for package Built with commit: eb47a754b0a4ee5d4d3a4b0104ab4cd44c92ace5 |
packages/carbon-web-components/src/components/side-panel/side-panel-button-set.ts
Outdated
Show resolved
Hide resolved
packages/carbon-web-components/src/components/side-panel/side-panel-story.mdx
Outdated
Show resolved
Hide resolved
packages/carbon-web-components/src/components/side-panel/side-panel.scss
Outdated
Show resolved
Hide resolved
packages/carbon-web-components/src/components/side-panel/side-panel.ts
Outdated
Show resolved
Hide resolved
packages/carbon-web-components/src/components/side-panel/side-panel.ts
Outdated
Show resolved
Hide resolved
packages/carbon-web-components/src/components/side-panel/side-panel.ts
Outdated
Show resolved
Hide resolved
packages/carbon-web-components/src/components/side-panel/side-panel-story.ts
Outdated
Show resolved
Hide resolved
lee-chase
force-pushed
the
feat/cwc-sidepanel
branch
from
5c340fc to
a151217
Compare
packages/carbon-web-components/examples/codesandbox/basic/components/side-panel/cdn.html
Outdated
Show resolved
Hide resolved
ariellalgilmore
approved these changes
Jan 31, 2024
Should not need a design review, should happen in @carbon/ibm-products for the side panel component. |
annawen1
approved these changes
Feb 1, 2024
ariellalgilmore
added
the
Ready to merge
kodiakhq
bot
merged commit c2c5bca
into
carbon-design-system:main
12 of 19 checks passed
kennylam
pushed a commit
to kennylam/carbon-for-ibm-dotcom
that referenced
this pull request
Jun 11, 2024
…#11201) Contributes to: carbon-design-system/carbon-labs#16 ### Description Very much a draft version of the SidePanel. It is currently based on the branch `clean_main`. It has a number of missing features Questions: - Button set does not re-order when stacked. I am uncertain if the behavior is possible with Web components - Story knobs not working as expected even when changing stories. Not found a declaration form that is either succinct or correctly updates even between stories. Ideally it should be possible to declare many stories with a single template and different default knobs. Review: - Feedback on the component produced so far would be useful, as it is the fist Web Component I have produced. For feature parity with the React SidePanel the following are required - [ ] button set to re-order when stacked - [ ] Selector-initial-focus not functional - [ ] Add 2nd step story - [ ] Fix action bar refresh bug - this is a circular resize/scroll issue in reality the HTML needs a refactor to correctly use sticky but that involves changing the IBM Products code carbon-design-system/ibm-products#4065 NOTES: - Storybooks feels a bit unwieldy for WebComponents, but that may just be use of V6 storybook.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to: carbon-design-system/carbon-labs#16
Description
Very much a draft version of the SidePanel.
It is currently based on the branch
clean_main.It has a number of missing features
Questions:
Review:
For feature parity with the React SidePanel the following are required
but that involves changing the IBM Products code Review Sidepanel title/header DOM structure for web component ibm-products#4065
NOTES: