Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stackblitz): fix and standardize masthead examples for v2 #11199

Merged
merged 21 commits into from
Jan 31, 2024
Merged

fix(stackblitz): fix and standardize masthead examples for v2 #11199

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
9eedc65
fix(codesandbox): fix and standardize masthead examples for v2 rc
jkaeser Dec 5, 2023
97c99a5
Merge branch 'main' into fix/masthead-codesandbox-examples
jkaeser Dec 11, 2023
3dfe8a5
fix(codesandbox): execute script after full DOM loads in
jkaeser Dec 14, 2023
378ee77
fix(codesandbox): update demo L1 data
jkaeser Dec 14, 2023
9cd372f
Merge branch 'main' into fix/masthead-codesandbox-examples
jkaeser Dec 14, 2023
1a9fe70
fix(codesandbox): use latest C4IBM web components version
jkaeser Dec 14, 2023
61435e4
Merge branch 'main' into fix/masthead-codesandbox-examples
jkaeser Dec 15, 2023
2ae18d5
Merge branch 'main' into fix/masthead-codesandbox-examples
jkaeser Dec 19, 2023
709f91e
Merge branch 'main' into fix/masthead-codesandbox-examples
jkaeser Dec 21, 2023
0495b58
fix(stackblitz): remove unnecessary lit-element references
jkaeser Jan 2, 2024
6ca9c68
Merge branch 'main' into fix/masthead-codesandbox-examples
jkaeser Jan 4, 2024
295c701
Merge branch 'main' into fix/masthead-codesandbox-examples
jkaeser Jan 8, 2024
3f9f498
Merge branch 'main' into fix/masthead-codesandbox-examples
jkaeser Jan 9, 2024
2e18cb1
Merge branch 'main' into fix/masthead-codesandbox-examples
jkaeser Jan 11, 2024
b6eb987
Merge branch 'main' into fix/masthead-codesandbox-examples
jkaeser Jan 11, 2024
e41dd0b
Merge branch 'main' into fix/masthead-codesandbox-examples
jkaeser Jan 18, 2024
94a8705
Merge branch 'main' into fix/masthead-codesandbox-examples
kennylam Jan 19, 2024
2e7fde0
Merge branch 'main' into fix/masthead-codesandbox-examples
jkaeser Jan 30, 2024
a343f3d
Merge branch 'main' into fix/masthead-codesandbox-examples
kodiakhq[bot] Jan 30, 2024
e9ebe63
Merge branch 'main' into fix/masthead-codesandbox-examples
jkaeser Jan 30, 2024
855f370
Merge branch 'main' into fix/masthead-codesandbox-examples
kennylam Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/web-components/examples/codesandbox/components/masthead-l1/.babelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,12 @@
}
]
],
"plugins": [["@babel/plugin-transform-runtime", { "version": "7.3.0" }]]
"plugins": [
[
"@babel/plugin-transform-runtime",
{
"version": "7.3.0"
}
]
]
}
18 changes: 14 additions & 4 deletions packages/web-components/examples/codesandbox/components/masthead-l1/cdn-rtl.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,25 @@
<link rel="stylesheet" href="src/index.scss" />
<style type="text/css">
/* Suppress custom element until styles are loaded */
cds-masthead-composite:not(:defined) {
c4d-masthead-container:not(:defined) {
display: none;
}
</style>
<script type="module" src="https://1.www.s81c.com/common/carbon-for-ibm-dotcom/tag/v1/latest/rtl/masthead.rtl.min.js"></script>
<script type="module" src="src/index-cdn.js"></script>
<script src="src/index-cdn.js" defer></script>
<script src="src/ddo.js"></script>

<!-- IBM Tag Management and Site Analytics -->
<script src="//1.www.s81c.com/common/stats/ibm-common.js" async="async" defer></script>
<!-- IBM CMaaS -->
<script src="//www.ibm.com/common/digitaladvisor/cm-app/latest/cm-app.min.js" defer></script>

<!-- CDN bundle -->
<script type="module" src="https://1.www.s81c.com/common/carbon-for-ibm-dotcom/tag/v2/latest/rtl/masthead.rtl.min.js"></script>
</head>
<body>
<cds-masthead-composite></cds-masthead-composite>
<c4d-masthead-container
data-endpoint="/common/carbon-for-ibm-dotcom/translations/masthead-footer/v2.1"
></c4d-masthead-container>
<main class="cds--content cds-ce-demo--ui-shell-content">
<div class="cds--grid">
<div class="cds--row">
Expand Down
18 changes: 14 additions & 4 deletions packages/web-components/examples/codesandbox/components/masthead-l1/cdn.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,25 @@
<link rel="stylesheet" href="src/index.scss" />
<style type="text/css">
/* Suppress custom element until styles are loaded */
cds-masthead-composite:not(:defined) {
c4d-masthead-container:not(:defined) {
display: none;
}
</style>
<script type="module" src="https://1.www.s81c.com/common/carbon-for-ibm-dotcom/tag/v1/latest/masthead.min.js"></script>
<script type="module" src="src/index-cdn.js"></script>
<script src="src/index-cdn.js" defer></script>
<script src="src/ddo.js"></script>

<!-- IBM Tag Management and Site Analytics -->
<script src="//1.www.s81c.com/common/stats/ibm-common.js" async="async" defer></script>
<!-- IBM CMaaS -->
<script src="//www.ibm.com/common/digitaladvisor/cm-app/latest/cm-app.min.js" defer></script>

<!-- CDN bundle -->
<script type="module" src="https://1.www.s81c.com/common/carbon-for-ibm-dotcom/tag/v2/latest/masthead.min.js"></script>
jkaeser marked this conversation as resolved.
Show resolved Hide resolved
</head>
<body>
<cds-masthead-composite></cds-masthead-composite>
<c4d-masthead-container
data-endpoint="/common/carbon-for-ibm-dotcom/translations/masthead-footer/v2.1"
></c4d-masthead-container>
<main class="cds--content cds-ce-demo--ui-shell-content">
<div class="cds--grid">
<div class="cds--row">
Expand Down
14 changes: 11 additions & 3 deletions packages/web-components/examples/codesandbox/components/masthead-l1/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,22 @@
<link rel="stylesheet" href="https://1.www.s81c.com/common/carbon-for-ibm-dotcom/tag/v1/latest/plex.css" />
<style type="text/css">
/* Suppress custom element until styles are loaded */
cds-masthead-composite:not(:defined) {
c4d-masthead-container:not(:defined) {
display: none;
}
</style>
<script type="module" src="src/index.js"></script>
<script src="src/index.js" defer></script>
<script src="src/ddo.js"></script>

<!-- IBM Tag Management and Site Analytics -->
<script src="//1.www.s81c.com/common/stats/ibm-common.js" async="async" defer></script>
<!-- IBM CMaaS -->
<script src="//www.ibm.com/common/digitaladvisor/cm-app/latest/cm-app.min.js" defer></script>
</head>
<body>
<cds-masthead-composite></cds-masthead-composite>
<c4d-masthead-container
data-endpoint="/common/carbon-for-ibm-dotcom/translations/masthead-footer/v2.1"
></c4d-masthead-container>
<main class="cds--content cds-ce-demo--ui-shell-content">
<div class="cds--grid">
<div class="cds--row">
Expand Down
5 changes: 2 additions & 3 deletions packages/web-components/examples/codesandbox/components/masthead-l1/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,12 @@
"build": "parcel build *.html --no-minify --public-url ./"
},
"dependencies": {
"@carbon/ibmdotcom-web-components": "latest"
"@carbon/ibmdotcom-web-components": "^2.0.0-rc"
},
"devDependencies": {
"@babel/core": "^7.0.0-0",
"@babel/plugin-transform-runtime": "^7.15.0",
"@babel/preset-env": "~7.23.2",
"carbon-components": "^10.36.0",
"lit-element": "^2.5.1",
"parcel-bundler": "1.12.3",
"rimraf": "^3.0.2",
"sass": "^1.32.13"
Expand Down
50 changes: 50 additions & 0 deletions packages/web-components/examples/codesandbox/components/masthead-l1/src/ddo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
/**
* @license
*
* Copyright IBM Corp. 2022, 2023
*
* This source code is licensed under the Apache-2.0 license found in the
* LICENSE file in the root directory of this source tree.
*/

import './index.scss';

window.digitalData = {
page: {
category: {
primaryCategory: '',
},
pageInfo: {
effectiveDate: '06-14-2022',
expiryDate: '06-14-2026',
language: 'en-au',
publishDate: '06-14-2022',
publisher: 'IBM Corporation',
version: 'Carbon for IBM.com',
ibm: {
contentDelivery: 'HTML',
contentProducer: 'IBM Experience Engine-Digital',
country: 'au',
industry: 'zz',
owner: 'Corporate Webmaster/New York/IBM',
siteID: 'GLOBAL',
subject: 'IBM Experience Engine-Digital',
type: 'zz',
messaging: {
routing: {
focusArea: 'Miscellaneous - Cross IBM - ISV',
languageCode: 'en',
regionCode: 'AU',
},
translation: {
languageCode: 'en',
regionCode: 'AU',
},
},
},
hotjar: {
enable: false,
},
},
},
};
Loading
Loading