Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(lint): yarn clean and style lint correction #11187

Closed
wants to merge 6 commits into from
Closed

fix(lint): yarn clean and style lint correction #11187

wants to merge 6 commits into from

Conversation

lee-chase
Copy link
Member

Related Ticket(s)

Description

  • When I downloaded the latest main I could not build and had to run yarn clean and generate a new lock file.
  • On trying to commit this the linter highlighted what appears to have been a } missed during a merge.

Changelog

Changed

  • packages/styles/scss/patterns/sections/leadspace/_leadspace.scss
  • yarn.lock

@lee-chase lee-chase requested a review from a team as a code owner December 4, 2023 16:01
@lee-chase lee-chase requested review from emyarod and annawen1 December 4, 2023 16:01
@jeffchew jeffchew changed the title Yarn clean and style lint correction fix(lint): yarn clean and style lint correction Dec 4, 2023
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 4, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11187/index.html

Built with commit: 6575f00934c9468c278007849cd66f1313e9423c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 4, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11187/index.html

Built with commit: 6575f00934c9468c278007849cd66f1313e9423c

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Dec 4, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11187/index.html

Built with commit: 6575f00934c9468c278007849cd66f1313e9423c

@kennylam kennylam self-requested a review December 6, 2023 15:03
@kennylam
Copy link
Member

kennylam commented Dec 6, 2023

Something is off with the footer in the dotcom-shell. In mobile breakpoints, the accordions are stuck open and cannot be closed.

image

@kennylam
Copy link
Member

kennylam commented Dec 6, 2023

Closing in favor of #11203

@kennylam kennylam closed this Dec 6, 2023
@lee-chase lee-chase deleted the cleaned_main branch December 7, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@kennylam kennylam Awaiting requested review from kennylam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lee-chase @ibmdotcom-bot @kennylam @jeffchew